From patchwork Thu Jan 7 08:26:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boichat X-Patchwork-Id: 12003139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D331C433DB for ; Thu, 7 Jan 2021 08:27:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BB0E23125 for ; Thu, 7 Jan 2021 08:27:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BB0E23125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FA246E40B; Thu, 7 Jan 2021 08:27:14 +0000 (UTC) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4239F6E40B for ; Thu, 7 Jan 2021 08:27:13 +0000 (UTC) Received: by mail-pj1-x102c.google.com with SMTP id w1so3735575pjc.0 for ; Thu, 07 Jan 2021 00:27:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VG/JPHW1nyFJkWn3hxAWpxYTfHmRQhs7/jRSVGbcaCA=; b=YIclqMxRK17U0P0NMoxt/Z+WcW8XzzwtBVqX3gpcdgcnk3PTRBRPCTIvlFvzEKpYp5 Gd43oJi+5M80ZT4X294OjTsmF3bM+v/S1WbhjoM8ymRkIHhlCCuM2uYeBKkrm+0aIYPD YKHL4xwlkSOagLE+JAzWlowpI6jgQX1x7aFgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VG/JPHW1nyFJkWn3hxAWpxYTfHmRQhs7/jRSVGbcaCA=; b=S6SSO66H/nnIalqVdi68v0+7/NOwcWJyn6RdrYxd4CULHybM/CrGGqaNFtc6p9bRhG iqVIFALo7mqtDuk36upMDApwjSUv5FO/84+2rROupVqORrvbaRkMktfZJALg/tiGZUPM fNt4Glig0oa7flH2Pm03cRytAvOkZSkvEpoiq1JIco9YlWBn2QAl3Ni3mECunx18Jges MgHh6zBq1CvIUQyxd+kzlt03caHfRrprXox0oT6fk5z8WXZTpdrLRalEWZb5onfGee0n WpA/XtAFL0EAuR/LZwP4TD2VWxniuVpUmClw2ZH/wyEI2cdYbg435NMWDLMlNL3vQJDN mIqw== X-Gm-Message-State: AOAM533YoFM4ybJj7NSc9W1/KfSg4WCgN/Knr1LNh8LCI6U+o4sR+TFX PYJ4zHxWY1fpFFcc3VmF3saYaw== X-Google-Smtp-Source: ABdhPJyxZnXxHUFuIui/rSg6OnuKbTGgDktbellBSXe/r4uAs+7zkOfP9EmPNCE0+2p1EBEit0h7eA== X-Received: by 2002:a17:902:7e85:b029:da:72a2:de1 with SMTP id z5-20020a1709027e85b02900da72a20de1mr8145955pla.57.1610008032888; Thu, 07 Jan 2021 00:27:12 -0800 (PST) Received: from drinkcat2.tpe.corp.google.com ([2401:fa00:1:b:7220:84ff:fe09:41dc]) by smtp.gmail.com with ESMTPSA id o14sm5825580pgr.44.2021.01.07.00.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 00:27:12 -0800 (PST) From: Nicolas Boichat To: Rob Herring , Steven Price , Alyssa Rosenzweig Subject: [PATCH v7 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1 Date: Thu, 7 Jan 2021 16:26:52 +0800 Message-Id: <20210107162632.v7.3.I3af068abe30c9c85cabc4486385c52e56527a509@changeid> X-Mailer: git-send-email 2.29.2.729.g45daf8777d-goog In-Reply-To: <20210107082653.3519337-1-drinkcat@chromium.org> References: <20210107082653.3519337-1-drinkcat@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Tomeu Vizoso , fshao@chromium.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, boris.brezillon@collabora.com, hsinyi@chromium.org, hoegsberg@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" GPUs with more than a single regulator (e.g. G72 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat --- Changes in v7: - Fix GPU ID in commit message Changes in v6: - New change drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index f44d28fad085..1f49043aae73 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -92,6 +92,15 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) struct thermal_cooling_device *cooling; struct panfrost_devfreq *pfdevfreq = &pfdev->pfdevfreq; + if (pfdev->comp->num_supplies > 1) { + /* + * GPUs with more than 1 supply require platform-specific handling: + * continue without devfreq + */ + DRM_DEV_ERROR(dev, "More than 1 supply is not supported yet\n"); + return 0; + } + opp_table = dev_pm_opp_set_regulators(dev, pfdev->comp->supply_names, pfdev->comp->num_supplies); if (IS_ERR(opp_table)) {