From patchwork Tue Jan 12 08:43:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 12012751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8699DC433DB for ; Tue, 12 Jan 2021 08:44:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3353922E00 for ; Tue, 12 Jan 2021 08:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3353922E00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AD986E13A; Tue, 12 Jan 2021 08:44:14 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF8996E135 for ; Tue, 12 Jan 2021 08:44:12 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id y17so1522829wrr.10 for ; Tue, 12 Jan 2021 00:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DiooeEYk8MkZJtYKRcyqrNpU6WznmViJg9DxY1OoaIA=; b=i2DPpL0P/JkC6czSQ4DlxhhNUCU5k3KY99uq62n6iLJZ5e/teH+8Dh+Ts9pdjCT1Qg hstBYlWdzWX0ZrG4/u2x+QAiq94dSt4+mtJQV4jVAjBPVpUGUrwJjfKBQCrC/Cip90YL jIyNarvh8qp8bW8OTddOHlovVUW85pJck053Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DiooeEYk8MkZJtYKRcyqrNpU6WznmViJg9DxY1OoaIA=; b=Ux9TAnuuZvybe9HKdi1emJL7E9Bsv5HyAwEiSWssNnTti5MtP392UaMxCQn75plkhO mNsaQ4CGdChIPETYrM4gZO4cfQSuUFN9Bd7BF2g9BKH2EpmCfIU+Ow/qXeANp5p+I+k2 mwrePdGOtXW1h2bIAkU/7JWmixVihOH1PSpnUyeLUp8/PUW8GaRXvptBu+nsMn1lLQXg 1f++DcM1/s/cJZYgGhwVKyE3U5sUFW+z+GeS7hbNG1IAceAt1NERfLUQ7FPPowVOYXyY tYB+kfZcEcaLAfnbjYnPj2meym7zUfE7TjzMHVeZni+tIrutlrTzF7N35W06EYK1xJWR SJ7w== X-Gm-Message-State: AOAM531EzMbBR8yp01eYi+DxvgOoYuDETYXyylrx6ukEHZ6sttJjZ1n3 /fvKq8VZyh+nG2QYl04SHQV+9kTP+8FHf8/z X-Google-Smtp-Source: ABdhPJzUuw1soLMQWzqcbs4erfwlqwMip2cgxF/dvbE5ad+pBRFKjJluyeOuT6Q9lYQg/ej339/yPw== X-Received: by 2002:a5d:6209:: with SMTP id y9mr3033138wru.197.1610441051232; Tue, 12 Jan 2021 00:44:11 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id j15sm3707017wrr.85.2021.01.12.00.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 00:44:10 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 06/15] drm/arc: Drop surplus connector registration Date: Tue, 12 Jan 2021 09:43:49 +0100 Message-Id: <20210112084358.2771527-6-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210112084358.2771527-1-daniel.vetter@ffwll.ch> References: <20210112084358.2771527-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eugeniy Paltsev , tiantao6@hisilicon.com, Alexey Brodkin , Sam Ravnborg , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" drm_connector_register does nothing before drm_dev_register(), it is meant for hotpluggable connectors only. Same for the unregister side. Acked-by: Sam Ravnborg Cc: Eugeniy Paltsev Signed-off-by: Daniel Vetter Cc: Alexey Brodkin --- drivers/gpu/drm/arc/arcpgu_sim.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_sim.c b/drivers/gpu/drm/arc/arcpgu_sim.c index e42fe5d05a3d..3772df1647aa 100644 --- a/drivers/gpu/drm/arc/arcpgu_sim.c +++ b/drivers/gpu/drm/arc/arcpgu_sim.c @@ -29,7 +29,6 @@ static int arcpgu_drm_connector_get_modes(struct drm_connector *connector) static void arcpgu_drm_connector_destroy(struct drm_connector *connector) { - drm_connector_unregister(connector); drm_connector_cleanup(connector); } @@ -80,7 +79,6 @@ int arcpgu_drm_sim_init(struct drm_device *drm, struct device_node *np) ret = drm_connector_attach_encoder(connector, encoder); if (ret < 0) { dev_err(drm->dev, "could not attach connector to encoder\n"); - drm_connector_unregister(connector); goto error_connector_cleanup; }