From patchwork Fri Jan 15 18:15:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12023709 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1812C433E6 for ; Fri, 15 Jan 2021 18:16:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8124F23A59 for ; Fri, 15 Jan 2021 18:16:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8124F23A59 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E57976E4CA; Fri, 15 Jan 2021 18:16:23 +0000 (UTC) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3722E6E4C5 for ; Fri, 15 Jan 2021 18:16:16 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id 7so2972813wrz.0 for ; Fri, 15 Jan 2021 10:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=ao9i4vgDHHQIUekQ87MHFQREuE2D0YpI1oA3cL0opjewp4Err83XY74KoQW+PUQcRb 5/OpZ0hdYs3gjXlaP4yjSWRMs8fpNjQkP5N5s+0qHuSdnNtrQNkslDD5dTRBpdk81T82 4WPof4xIye7KPIpjykKw+as/Cvbr9v1Rl35atrE3W11DRTGEVwpo/EwHgUrj5ekuqI7L UUn7enAqQxpHwWjStPF8uo8DaTyvkZ9pdHdvzPePM1Q8OkvY0mpwg96l4+z6Iw6+1tC0 bxLNZbk/UNcrrkbxvO9Xtzv6XjYJ/EbZQr8gLmniTqceS+jGGfITIBLFZYamuuJSqY2e Qc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GmnTQYGZFT8V4aHtRElOATkEuVPQEpEkCVYessHQgb4=; b=lRQMvVfas8oWuIHdwOovAkCJ5NgCBFhoV7i9I7fxuiJcnequ7f/FHok8Rs/7wJtwU+ Z3ERQ645wqDO3046ARCAih+O9Gvd99WJCCl8l/vScRCYEcsJgmy6P55MSJ1VVX/cpfqE 1+047PpLAIlIcUF1ZOvLn3/DShmmv0kMnOJnIkqBEhZSgagep46cyv0Ar+QIyJovI/FI wvWlVYQqFwU9GFxyguuMQsi/p0XsvdFpoRtYxGCGQpzznoWhY9Z/Gw/ovBUvNut+W694 zzR/6Q9u5BnU21VNeiprrJfDp4sNDRTqKFQ39iKe+VnD+9kPN4RLeRAdP5MIKNBdTpOR Gh5Q== X-Gm-Message-State: AOAM531KFodedmdkuhjDX7cOIHN+Fzz28MK2VjyrZcVKFG+u7kSA88rD WujnqO/jhPD2dHe7UxLZToLfKw== X-Google-Smtp-Source: ABdhPJym4/tW0/UVxoaeFRN8gzoR+0lDT/OQGytPzdRqN6VKamUOSS/5kWdr2iqHm14l/DYCyWCijA== X-Received: by 2002:adf:92a4:: with SMTP id 33mr14241917wrn.347.1610734574855; Fri, 15 Jan 2021 10:16:14 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id b133sm14405979wme.33.2021.01.15.10.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 10:16:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/29] drm/gma500/mmu: Actually return an error if one occurs Date: Fri, 15 Jan 2021 18:15:38 +0000 Message-Id: <20210115181601.3432599-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115181601.3432599-1-lee.jones@linaro.org> References: <20210115181601.3432599-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/gma500/mmu.c: In function ‘psb_mmu_insert_pfn_sequence’: drivers/gpu/drm/gma500/mmu.c:651:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Patrik Jakobsson Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/gma500/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 014daf0280485..13aff19aae9ba 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c @@ -681,7 +681,7 @@ int psb_mmu_insert_pfn_sequence(struct psb_mmu_pd *pd, uint32_t start_pfn, if (pd->hw_context != -1) psb_mmu_flush(pd->driver); - return 0; + return ret; } int psb_mmu_insert_pages(struct psb_mmu_pd *pd, struct page **pages,