diff mbox series

[v4] drm: Improve the output_poll_changed description

Message ID 20210121030909.1126643-1-zhangzhijie@loongson.cn (mailing list archive)
State New, archived
Headers show
Series [v4] drm: Improve the output_poll_changed description | expand

Commit Message

ZhiJie.Zhang Jan. 21, 2021, 3:09 a.m. UTC
From: zhangzhijie <zhangzhijie@loongson.cn>

this callback was used by drm_kms_helper_hotplug_event()

V2: (Thanks for Daniel's suggestions)
- remove the FIXME below.since with the drm_client
- infrastructure and the generic fbdev emulation we've
- resolved this all very neatly now.

V3: Add comments that This hook is deprecated
- new implementation methods instead of this hook

Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
---
 include/drm/drm_mode_config.h | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Comments

Daniel Vetter Jan. 21, 2021, 11:23 a.m. UTC | #1
On Thu, Jan 21, 2021 at 4:09 AM ZhiJie.Zhang <zhangzhijie@loongson.cn> wrote:
>
> From: zhangzhijie <zhangzhijie@loongson.cn>
>
> this callback was used by drm_kms_helper_hotplug_event()
>
> V2: (Thanks for Daniel's suggestions)
> - remove the FIXME below.since with the drm_client
> - infrastructure and the generic fbdev emulation we've
> - resolved this all very neatly now.
>
> V3: Add comments that This hook is deprecated
> - new implementation methods instead of this hook
>
> Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn>
> ---
>  include/drm/drm_mode_config.h | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index ab424ddd7665..fbc0da25d7c5 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -103,14 +103,13 @@ struct drm_mode_config_funcs {
>          * Callback used by helpers to inform the driver of output configuration
>          * changes.
>          *
> -        * Drivers implementing fbdev emulation with the helpers can call
> -        * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
> -        * helper of output changes.

Not sure why this isn't clear, but the above is important information
that we should keep. Maybe good to fix up the formatting to make it a
hyperlink, and your addition here is fine too, but the above is the
important part really.
-Daniel

> +        * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
> +        * to call this hook to inform the fbdev helper of output changes.
>          *
> -        * FIXME:
> -        *
> -        * Except that there's no vtable for device-level helper callbacks
> -        * there's no reason this is a core function.
> +        * This hook is deprecated, drivers should instead use
> +        * drm_fbdev_generic_setup() which takes care of any necessary
> +        * hotplug event forwarding already without further involvement by
> +        * the driver.
>          */
>         void (*output_poll_changed)(struct drm_device *dev);
>
> --
> 2.29.2
>
diff mbox series

Patch

diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
index ab424ddd7665..fbc0da25d7c5 100644
--- a/include/drm/drm_mode_config.h
+++ b/include/drm/drm_mode_config.h
@@ -103,14 +103,13 @@  struct drm_mode_config_funcs {
 	 * Callback used by helpers to inform the driver of output configuration
 	 * changes.
 	 *
-	 * Drivers implementing fbdev emulation with the helpers can call
-	 * drm_fb_helper_hotplug_changed from this hook to inform the fbdev
-	 * helper of output changes.
+	 * Drivers implementing fbdev emulation use drm_kms_helper_hotplug_event()
+	 * to call this hook to inform the fbdev helper of output changes.
 	 *
-	 * FIXME:
-	 *
-	 * Except that there's no vtable for device-level helper callbacks
-	 * there's no reason this is a core function.
+	 * This hook is deprecated, drivers should instead use
+	 * drm_fbdev_generic_setup() which takes care of any necessary
+	 * hotplug event forwarding already without further involvement by
+	 * the driver.
 	 */
 	void (*output_poll_changed)(struct drm_device *dev);