| Message ID | 20210221152524.197693-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line | expand |
Reviewed-by: Alex Shi <alex.shi@linux.alibaba.com> 在 2021/2/21 下午11:25, Masahiro Yamada 写道: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in arch/mips/kvm/Makefile (and possibly in external > modules too). Passing EXTRA_CFLAGS from the command line overwrites > it and breaks the build. > > I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7 > ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in > EXTRA_CFLAGS") was based on the same misunderstanding. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Documentation/process/4.Coding.rst | 2 +- > Documentation/process/submit-checklist.rst | 2 +- > Documentation/translations/it_IT/process/4.Coding.rst | 2 +- > Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- > Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- > drivers/gpu/drm/tilcdc/Makefile | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) >
On 2021-02-21 16:25, Masahiro Yamada wrote: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in arch/mips/kvm/Makefile (and possibly in external > modules too). Passing EXTRA_CFLAGS from the command line overwrites > it and breaks the build. > > I also fixed drivers/gpu/drm/tilcdc/Makefile because commit > 816175dd1fd7 > ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in > EXTRA_CFLAGS") was based on the same misunderstanding. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Documentation/process/4.Coding.rst | 2 +- > Documentation/process/submit-checklist.rst | 2 +- > Documentation/translations/it_IT/process/4.Coding.rst | 2 +- > Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- > Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- > drivers/gpu/drm/tilcdc/Makefile | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) Acked-by: Federico Vaga <federico.vaga@vaga.pv.it>
Masahiro Yamada <masahiroy@kernel.org> writes: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in arch/mips/kvm/Makefile (and possibly in external > modules too). Passing EXTRA_CFLAGS from the command line overwrites > it and breaks the build. > > I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7 > ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in > EXTRA_CFLAGS") was based on the same misunderstanding. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > Documentation/process/4.Coding.rst | 2 +- > Documentation/process/submit-checklist.rst | 2 +- > Documentation/translations/it_IT/process/4.Coding.rst | 2 +- > Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- > Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- > drivers/gpu/drm/tilcdc/Makefile | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) I've applied this, fixing the conflict with submit-checklist.rst in the process. Thanks, jon
diff --git a/Documentation/process/4.Coding.rst b/Documentation/process/4.Coding.rst index 0825dc496f22..1f0d81f44e14 100644 --- a/Documentation/process/4.Coding.rst +++ b/Documentation/process/4.Coding.rst @@ -242,7 +242,7 @@ and try to avoid "fixes" which make the warning go away without addressing its cause. Note that not all compiler warnings are enabled by default. Build the -kernel with "make EXTRA_CFLAGS=-W" to get the full set. +kernel with "make KCFLAGS=-W" to get the full set. The kernel provides several configuration options which turn on debugging features; most of these are found in the "kernel hacking" submenu. Several diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst index 230ee42f872f..cfc23492b9ea 100644 --- a/Documentation/process/submit-checklist.rst +++ b/Documentation/process/submit-checklist.rst @@ -98,7 +98,7 @@ and elsewhere regarding submitting Linux kernel patches. injection might be appropriate. 21) Newly-added code has been compiled with ``gcc -W`` (use - ``make EXTRA_CFLAGS=-W``). This will generate lots of noise, but is good + ``make KCFLAGS=-W``). This will generate lots of noise, but is good for finding bugs like "warning: comparison between signed and unsigned". 22) Tested after it has been merged into the -mm patchset to make sure diff --git a/Documentation/translations/it_IT/process/4.Coding.rst b/Documentation/translations/it_IT/process/4.Coding.rst index a5e36aa60448..8012fe9497ae 100644 --- a/Documentation/translations/it_IT/process/4.Coding.rst +++ b/Documentation/translations/it_IT/process/4.Coding.rst @@ -256,7 +256,7 @@ e cercate di evitare le "riparazioni" che fan sparire l'avvertimento senza però averne trovato la causa. Tenete a mente che non tutti gli avvertimenti sono disabilitati di default. -Costruite il kernel con "make EXTRA_CFLAGS=-W" per ottenerli tutti. +Costruite il kernel con "make KCFLAGS=-W" per ottenerli tutti. Il kernel fornisce differenti opzioni che abilitano funzionalità di debugging; molti di queste sono trovano all'interno del sotto menu "kernel hacking". diff --git a/Documentation/translations/it_IT/process/submit-checklist.rst b/Documentation/translations/it_IT/process/submit-checklist.rst index 3e575502690f..614fc17d9086 100644 --- a/Documentation/translations/it_IT/process/submit-checklist.rst +++ b/Documentation/translations/it_IT/process/submit-checklist.rst @@ -104,7 +104,7 @@ sottomissione delle patch, in particolare l'iniezione di fallimenti specifici per il sottosistema. 22) Il nuovo codice è stato compilato con ``gcc -W`` (usate - ``make EXTRA_CFLAGS=-W``). Questo genererà molti avvisi, ma è ottimo + ``make KCFLAGS=-W``). Questo genererà molti avvisi, ma è ottimo per scovare bachi come "warning: comparison between signed and unsigned". 23) La patch è stata verificata dopo essere stata inclusa nella serie di patch diff --git a/Documentation/translations/zh_CN/process/4.Coding.rst b/Documentation/translations/zh_CN/process/4.Coding.rst index 959a06ba025c..66cd8ee07606 100644 --- a/Documentation/translations/zh_CN/process/4.Coding.rst +++ b/Documentation/translations/zh_CN/process/4.Coding.rst @@ -165,7 +165,7 @@ Linus对这个问题给出了最佳答案: 通常，这些警告都指向真正的问题。提交以供审阅的代码通常不会产生任何编译器警告。 在消除警告时，注意了解真正的原因，并尽量避免“修复”，使警告消失而不解决其原因。 -请注意，并非所有编译器警告都默认启用。使用“make EXTRA_CFLAGS=-W”构建内核以 +请注意，并非所有编译器警告都默认启用。使用“make KCFLAGS=-W”构建内核以 获得完整集合。 内核提供了几个配置选项，可以打开调试功能；大多数配置选项位于“kernel hacking” diff --git a/drivers/gpu/drm/tilcdc/Makefile b/drivers/gpu/drm/tilcdc/Makefile index 662bf3a348c9..f5190477de72 100644 --- a/drivers/gpu/drm/tilcdc/Makefile +++ b/drivers/gpu/drm/tilcdc/Makefile @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 -ifeq (, $(findstring -W,$(EXTRA_CFLAGS))) +ifeq (, $(findstring -W,$(KCFLAGS))) ccflags-y += -Werror endif
You should use KCFLAGS to pass additional compiler flags from the command line. Using EXTRA_CFLAGS is wrong. EXTRA_CFLAGS is supposed to specify flags applied only to the current Makefile (and now deprecated in favor of ccflags-y). It is still used in arch/mips/kvm/Makefile (and possibly in external modules too). Passing EXTRA_CFLAGS from the command line overwrites it and breaks the build. I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7 ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in EXTRA_CFLAGS") was based on the same misunderstanding. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Documentation/process/4.Coding.rst | 2 +- Documentation/process/submit-checklist.rst | 2 +- Documentation/translations/it_IT/process/4.Coding.rst | 2 +- Documentation/translations/it_IT/process/submit-checklist.rst | 2 +- Documentation/translations/zh_CN/process/4.Coding.rst | 2 +- drivers/gpu/drm/tilcdc/Makefile | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)