| Message ID | 20210412000158.2049066-1-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/dsi: fix msm_dsi_phy_get_clk_provider return code | expand |
Hi On 12/04/2021 03:01, Dmitry Baryshkov wrote: > msm_dsi_phy_get_clk_provider() always returns two provided clocks, so > return 0 instead of returning incorrect -EINVAL error code. > > Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I wanted to ping/remind regarding this patch and regarding https://lore.kernel.org/linux-arm-msm/20210410011901.1735866-1-dmitry.baryshkov@linaro.org/ It would be great to get those two fixes in linux-next or early during 5.14 cycle. > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index f0a2ddf96a4b..ff7f2ec42030 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -843,7 +843,7 @@ int msm_dsi_phy_get_clk_provider(struct msm_dsi_phy *phy, > if (pixel_clk_provider) > *pixel_clk_provider = phy->provided_clocks->hws[DSI_PIXEL_PLL_CLK]->clk; > > - return -EINVAL; > + return 0; > } > > void msm_dsi_phy_pll_save_state(struct msm_dsi_phy *phy) >
On 2021-04-11 17:01, Dmitry Baryshkov wrote: > msm_dsi_phy_get_clk_provider() always returns two provided clocks, so > return 0 instead of returning incorrect -EINVAL error code. > > Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into > a generic code") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index f0a2ddf96a4b..ff7f2ec42030 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -843,7 +843,7 @@ int msm_dsi_phy_get_clk_provider(struct msm_dsi_phy > *phy, > if (pixel_clk_provider) > *pixel_clk_provider = > phy->provided_clocks->hws[DSI_PIXEL_PLL_CLK]->clk; > > - return -EINVAL; > + return 0; > } > > void msm_dsi_phy_pll_save_state(struct msm_dsi_phy *phy)
Tested-by: Jonathan Marek <jonathan@marek.ca> On 4/11/21 8:01 PM, Dmitry Baryshkov wrote: > msm_dsi_phy_get_clk_provider() always returns two provided clocks, so > return 0 instead of returning incorrect -EINVAL error code. > > Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > index f0a2ddf96a4b..ff7f2ec42030 100644 > --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c > @@ -843,7 +843,7 @@ int msm_dsi_phy_get_clk_provider(struct msm_dsi_phy *phy, > if (pixel_clk_provider) > *pixel_clk_provider = phy->provided_clocks->hws[DSI_PIXEL_PLL_CLK]->clk; > > - return -EINVAL; > + return 0; > } > > void msm_dsi_phy_pll_save_state(struct msm_dsi_phy *phy) >
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index f0a2ddf96a4b..ff7f2ec42030 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -843,7 +843,7 @@ int msm_dsi_phy_get_clk_provider(struct msm_dsi_phy *phy, if (pixel_clk_provider) *pixel_clk_provider = phy->provided_clocks->hws[DSI_PIXEL_PLL_CLK]->clk; - return -EINVAL; + return 0; } void msm_dsi_phy_pll_save_state(struct msm_dsi_phy *phy)
msm_dsi_phy_get_clk_provider() always returns two provided clocks, so return 0 instead of returning incorrect -EINVAL error code. Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)