| Message ID | 20210412122056.28351-2-fmdefrancesco@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu: drm: Change types and format comments | expand |
On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco <fmdefrancesco@gmail.com> wrote: > > Replaced "unsigned with "unsigned int" since the latter is preferred. > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> Nit for the subjects: In drm we generally don't have the gpu prefix, but just the level below + what component. So for these two patches it would be drm/atomic-helpers: as prefix in the patch summary lines. Can you pls adjust that? Patches look good otherwise. Thanks, Daniel > --- > drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index f2b3e28d938b..cd748ff61162 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -106,7 +106,7 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, > struct drm_connector *connector; > struct drm_connector_list_iter conn_iter; > struct drm_encoder *encoder; > - unsigned encoder_mask = 0; > + unsigned int encoder_mask = 0; > int i, ret = 0; > > /* > @@ -609,7 +609,7 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, > struct drm_connector *connector; > struct drm_connector_state *old_connector_state, *new_connector_state; > int i, ret; > - unsigned connectors_mask = 0; > + unsigned int connectors_mask = 0; > > for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) { > bool has_connectors = > @@ -1478,7 +1478,7 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev, > struct drm_crtc *crtc; > struct drm_crtc_state *old_crtc_state, *new_crtc_state; > int i, ret; > - unsigned crtc_mask = 0; > + unsigned int crtc_mask = 0; > > /* > * Legacy cursor ioctls are completely unsynced, and userspace > @@ -2575,7 +2575,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) > struct drm_crtc_state *new_crtc_state = > drm_atomic_get_new_crtc_state(old_state, crtc); > struct drm_plane *plane; > - unsigned plane_mask; > + unsigned int plane_mask; > > plane_mask = old_crtc_state->plane_mask; > plane_mask |= new_crtc_state->plane_mask; > -- > 2.31.1 >
On Mon, 12 Apr 2021, Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco > <fmdefrancesco@gmail.com> wrote: > > > > Replaced "unsigned with "unsigned int" since the latter is preferred. > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> > > Nit for the subjects: In drm we generally don't have the gpu prefix, > but just the level below + what component. So for these two patches it > would be drm/atomic-helpers: as prefix in the patch summary lines. Can > you pls adjust that? Patches look good otherwise. Fabio, you should select the subject line by looking at what others have done on the same file (git log --oneline file.c). Different parts of the kernel have different strategies, so it is better to check every time. julia > Thanks, Daniel > > > --- > > drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > > index f2b3e28d938b..cd748ff61162 100644 > > --- a/drivers/gpu/drm/drm_atomic_helper.c > > +++ b/drivers/gpu/drm/drm_atomic_helper.c > > @@ -106,7 +106,7 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, > > struct drm_connector *connector; > > struct drm_connector_list_iter conn_iter; > > struct drm_encoder *encoder; > > - unsigned encoder_mask = 0; > > + unsigned int encoder_mask = 0; > > int i, ret = 0; > > > > /* > > @@ -609,7 +609,7 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, > > struct drm_connector *connector; > > struct drm_connector_state *old_connector_state, *new_connector_state; > > int i, ret; > > - unsigned connectors_mask = 0; > > + unsigned int connectors_mask = 0; > > > > for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) { > > bool has_connectors = > > @@ -1478,7 +1478,7 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev, > > struct drm_crtc *crtc; > > struct drm_crtc_state *old_crtc_state, *new_crtc_state; > > int i, ret; > > - unsigned crtc_mask = 0; > > + unsigned int crtc_mask = 0; > > > > /* > > * Legacy cursor ioctls are completely unsynced, and userspace > > @@ -2575,7 +2575,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) > > struct drm_crtc_state *new_crtc_state = > > drm_atomic_get_new_crtc_state(old_state, crtc); > > struct drm_plane *plane; > > - unsigned plane_mask; > > + unsigned int plane_mask; > > > > plane_mask = old_crtc_state->plane_mask; > > plane_mask |= new_crtc_state->plane_mask; > > -- > > 2.31.1 > > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKMK7uEzf64xB5TLS7VvyLVJmX4MBNnHcr3_n1zDq3hOVAm1Rg%40mail.gmail.com. >
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index f2b3e28d938b..cd748ff61162 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -106,7 +106,7 @@ static int handle_conflicting_encoders(struct drm_atomic_state *state, struct drm_connector *connector; struct drm_connector_list_iter conn_iter; struct drm_encoder *encoder; - unsigned encoder_mask = 0; + unsigned int encoder_mask = 0; int i, ret = 0; /* @@ -609,7 +609,7 @@ drm_atomic_helper_check_modeset(struct drm_device *dev, struct drm_connector *connector; struct drm_connector_state *old_connector_state, *new_connector_state; int i, ret; - unsigned connectors_mask = 0; + unsigned int connectors_mask = 0; for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) { bool has_connectors = @@ -1478,7 +1478,7 @@ drm_atomic_helper_wait_for_vblanks(struct drm_device *dev, struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state, *new_crtc_state; int i, ret; - unsigned crtc_mask = 0; + unsigned int crtc_mask = 0; /* * Legacy cursor ioctls are completely unsynced, and userspace @@ -2575,7 +2575,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state) struct drm_crtc_state *new_crtc_state = drm_atomic_get_new_crtc_state(old_state, crtc); struct drm_plane *plane; - unsigned plane_mask; + unsigned int plane_mask; plane_mask = old_crtc_state->plane_mask; plane_mask |= new_crtc_state->plane_mask;
Replaced "unsigned with "unsigned int" since the latter is preferred. Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> --- drivers/gpu/drm/drm_atomic_helper.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)