diff mbox series

[1/3] drm/amdgpu: make sure we unpin the UVD BO

Message ID 20210415084730.2057-1-christian.koenig@amd.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/amdgpu: make sure we unpin the UVD BO | expand

Commit Message

Christian König April 15, 2021, 8:47 a.m. UTC 
Releasing pinned BOs is illegal now.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christian König April 16, 2021, 12:54 p.m. UTC | #1 
Ping?

Am 15.04.21 um 10:47 schrieb Christian König:
> Releasing pinned BOs is illegal now.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> index 7cd67cb2ac5f..1a2bf2ca1be5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
> @@ -363,6 +363,7 @@ static int uvd_v7_0_enc_ring_test_ib(struct amdgpu_ring *ring, long timeout)
>   
>   error:
>   	dma_fence_put(fence);
> +	amdgpu_bo_unpin(bo);
>   	amdgpu_bo_unreserve(bo);
>   	amdgpu_bo_unref(&bo);
>   	return r;
Leo Liu April 16, 2021, 2:35 p.m. UTC | #2 
Acked-by: Leo Liu <leo.liu@amd.com>

On 2021-04-16 8:54 a.m., Christian König wrote:
> Ping?
>
> Am 15.04.21 um 10:47 schrieb Christian König:
>> Releasing pinned BOs is illegal now.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c 
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
>> index 7cd67cb2ac5f..1a2bf2ca1be5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
>> @@ -363,6 +363,7 @@ static int uvd_v7_0_enc_ring_test_ib(struct 
>> amdgpu_ring *ring, long timeout)
>>     error:
>>       dma_fence_put(fence);
>> +    amdgpu_bo_unpin(bo);
>>       amdgpu_bo_unreserve(bo);
>>       amdgpu_bo_unref(&bo);
>>       return r;
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Cleo.liu%40amd.com%7C5823d278fae848e2292008d900d6bd76%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637541744618109453%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=TIn5u5%2FPS50wcKCd6%2FwTnpPm%2BgCPa8KOT1cz6r7Xgl0%3D&amp;reserved=0 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
index 7cd67cb2ac5f..1a2bf2ca1be5 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c
@@ -363,6 +363,7 @@  static int uvd_v7_0_enc_ring_test_ib(struct amdgpu_ring *ring, long timeout)
 
 error:
 	dma_fence_put(fence);
+	amdgpu_bo_unpin(bo);
 	amdgpu_bo_unreserve(bo);
 	amdgpu_bo_unref(&bo);
 	return r;