From patchwork Fri Apr 23 22:31:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Ekstrand X-Patchwork-Id: 12221871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D16DFC433ED for ; Fri, 23 Apr 2021 22:32:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E7586101D for ; Fri, 23 Apr 2021 22:32:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E7586101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jlekstrand.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F176D6ECC0; Fri, 23 Apr 2021 22:32:00 +0000 (UTC) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by gabe.freedesktop.org (Postfix) with ESMTPS id A54346ECB4 for ; Fri, 23 Apr 2021 22:31:51 +0000 (UTC) Received: by mail-pj1-x102c.google.com with SMTP id u11so20173565pjr.0 for ; Fri, 23 Apr 2021 15:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ma+rRutCb3Np4s5BqSjRFviPoeCa4Gjfgvb/I+UNmhg=; b=N71bO9/P9B5Jc+nxx044jW2XVLbU/Nvll4YzI68RtEMussGiPMuBlMJJtoT6OAPRFa VC85c81NbZ8D9w0WnpqnBmN9hP6hEzLZ+e+RzblR0ufQO5L40TFNmWYfCZOg0UZo0edx yDOJi7g9xe+uDpgHr9KV/qiz9Jm5Y7qMsGjDV5V9adXvDoUAZxDrtgyQUdKSVlpaW6/8 acorOJYvKfOP100CfEHuvYr8qBeZ964POnzGAWmg4u15cWiFq+i3lI5SeESnse4BCMrt jhLog7Nuhx0z0XhCo4pVu5zPnxcO4th89uvfIXQrkRx0yqyDk/eo7utH1DHfgQ6/WccM SfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ma+rRutCb3Np4s5BqSjRFviPoeCa4Gjfgvb/I+UNmhg=; b=a6W6F37rHF+qC72Fq7hH8QNEm746EaLBdx6SlOF4/DQaOoOz5GADUFNvLRWjAK/IaP odhSqj/CuumQY2fNTXnJc+NEOr+q2QNHu2RHmOuwF9kncQdaKJ8zt96HyJmLjoDeaQ2o V657RBrdMAzrfeyAHtcm/qMtBZau4tdeMHKfEb28EpdUjGDZ82J48DIvYZhs1nYDLN3e PkeQlg70nl3K0b857uud+W3JUhMsdNblhFD7aPn+dbUH1WGn+t7PySRBJthFu9SlXFhb w85zyPJxbIF8C230EXQjsOBPiUiJoZtHRRaTlPQ9Q2XdlXPv8iMVXYYJHp3tCzXHpHrJ xMfw== X-Gm-Message-State: AOAM532RjEOWNxZ4ce7tWlGKk/r/x02zwTtZdWETTsqy3cWhAVUJWn74 CsrP3POhEBmITKaj4CGjNd3MFQ== X-Google-Smtp-Source: ABdhPJxiOdy+1nMvIP7uEoxmDhQb1Z7eYEnvQJslzqpIATO6sTLK7CMyrueEi86qsEABGTHmkro9gQ== X-Received: by 2002:a17:90a:430e:: with SMTP id q14mr8340009pjg.189.1619217111203; Fri, 23 Apr 2021 15:31:51 -0700 (PDT) Received: from omlet.com ([134.134.139.76]) by smtp.gmail.com with ESMTPSA id z12sm5523420pfn.195.2021.04.23.15.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Apr 2021 15:31:50 -0700 (PDT) From: Jason Ekstrand To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 09/21] drm/i915/gem: Disallow creating contexts with too many engines Date: Fri, 23 Apr 2021 17:31:19 -0500 Message-Id: <20210423223131.879208-10-jason@jlekstrand.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210423223131.879208-1-jason@jlekstrand.net> References: <20210423223131.879208-1-jason@jlekstrand.net> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Ekstrand Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There's no sense in allowing userspace to create more engines than it can possibly access via execbuf. Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 5f8d0faf783aa..ecb3bf5369857 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -1640,11 +1640,10 @@ set_engines(struct i915_gem_context *ctx, return -EINVAL; } - /* - * Note that I915_EXEC_RING_MASK limits execbuf to only using the - * first 64 engines defined here. - */ num_engines = (args->size - sizeof(*user)) / sizeof(*user->engines); + if (num_engines > I915_EXEC_RING_MASK + 1) + return -EINVAL; + set.engines = alloc_engines(num_engines); if (!set.engines) return -ENOMEM;