diff mbox series

[v2] drm/bridge: anx7625: Fix power on delay

Message ID 20210428115116.931328-1-hsinyi@chromium.org (mailing list archive)
State New, archived
Headers show
Series [v2] drm/bridge: anx7625: Fix power on delay | expand

Commit Message

Hsin-Yi Wang April 28, 2021, 11:51 a.m. UTC
From anx7625 spec, the delay between powering on power supplies and gpio
should be larger than 10ms.

Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power off")
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
v1->v2: Extend sleep range a bit as the regulator on some device takes
more time to be powered on after regulator_enable() is called.
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Robert Foss April 28, 2021, 3:46 p.m. UTC | #1
Merged.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1fcf24fb07e254ca69001ab14adc8cf567127c44

On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang <hsinyi@chromium.org> wrote:

> From anx7625 spec, the delay between powering on power supplies and gpio
> should be larger than 10ms.
>
> Fixes: 6c744983004e ("drm/bridge: anx7625: disable regulators when power
> off")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> v1->v2: Extend sleep range a bit as the regulator on some device takes
> more time to be powered on after regulator_enable() is called.
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 23283ba0c4f9..b4e349ca38fe 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -893,7 +893,7 @@ static void anx7625_power_on(struct anx7625_data *ctx)
>                 usleep_range(2000, 2100);
>         }
>
> -       usleep_range(4000, 4100);
> +       usleep_range(11000, 12000);
>
>         /* Power on pin enable */
>         gpiod_set_value(ctx->pdata.gpio_p_on, 1);
> --
> 2.31.1.498.g6c1eba8ee3d-goog
>
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 23283ba0c4f9..b4e349ca38fe 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -893,7 +893,7 @@  static void anx7625_power_on(struct anx7625_data *ctx)
 		usleep_range(2000, 2100);
 	}
 
-	usleep_range(4000, 4100);
+	usleep_range(11000, 12000);
 
 	/* Power on pin enable */
 	gpiod_set_value(ctx->pdata.gpio_p_on, 1);