drm: Declare drm_send_event_helper static.

Commit Message

Rajat Asthana May 9, 2021, 1:42 p.m. UTC

From: Rajat <[e-mail]>

Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat <[e-mail]>
---
 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard May 10, 2021, 12:32 p.m. UTC | #1

Hi,

On Sun, May 09, 2021 at 07:12:52PM +0530, Rajat Asthana wrote:
> From: Rajat <[e-mail]>
> 
> Declare drm_send_event_helper as static to fix sparse warning:
> 
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
> 
> Signed-off-by: Rajat <[e-mail]>

Both the Author and Signed-off-by should have your full name

Thanks!
Maxime

Patch

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@  EXPORT_SYMBOL(drm_event_cancel_free);
  * The timestamp variant of dma_fence_signal is used when the caller
  * sends a valid timestamp.
  */
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
 			   struct drm_pending_event *e, ktime_t timestamp)
 {
 	assert_spin_locked(&dev->event_lock);