diff mbox series

[v2] drm: Declare drm_send_event_helper static.

Message ID 20210510131616.544547-1-thisisrast7@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2] drm: Declare drm_send_event_helper static. | expand

Commit Message

Rajat Asthana May 10, 2021, 1:16 p.m. UTC
Declare drm_send_event_helper as static to fix sparse warning:

> warning: symbol 'drm_send_event_helper' was not declared.
> Should it be static?

Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
---
Changes in v2:
    Provide full name in Author and Signed-off.

 drivers/gpu/drm/drm_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck May 10, 2021, 10:35 p.m. UTC | #1
On Mon, May 10, 2021 at 06:46:16PM +0530, Rajat Asthana wrote:
> Declare drm_send_event_helper as static to fix sparse warning:
> 
> > warning: symbol 'drm_send_event_helper' was not declared.
> > Should it be static?
> 
> Signed-off-by: Rajat Asthana <thisisrast7@gmail.com>
> ---
> Changes in v2:
>     Provide full name in Author and Signed-off.
> 

Turns out a variant of this patch [1] has already been accepted.

Guenter

---
[1] https://patchwork.kernel.org/project/dri-devel/patch/20210427105503.10765-1-fmdefrancesco@gmail.com/
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
index 7efbccffc2ea..17f38d873972 100644
--- a/drivers/gpu/drm/drm_file.c
+++ b/drivers/gpu/drm/drm_file.c
@@ -786,7 +786,7 @@  EXPORT_SYMBOL(drm_event_cancel_free);
  * The timestamp variant of dma_fence_signal is used when the caller
  * sends a valid timestamp.
  */
-void drm_send_event_helper(struct drm_device *dev,
+static void drm_send_event_helper(struct drm_device *dev,
 			   struct drm_pending_event *e, ktime_t timestamp)
 {
 	assert_spin_locked(&dev->event_lock);