| Message ID | 20210713133230.GA1872993@pc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu: ipu-v3: use swap() | expand |
Hi Salah, On Tue, Jul 13, 2021 at 10:33 AM Salah Triki <salah.triki@gmail.com> wrote: > > Use swap() instead of implementing it since it makes code more clean. s/more clean/cleaner > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c > index aa1d4b6d278f..5f730cd6009d 100644 > --- a/drivers/gpu/ipu-v3/ipu-image-convert.c > +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c > @@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx, > > u_off = y_size - y_off + uv_off; > v_off = (fmt->uv_packed) ? 0 : u_off + uv_size; > - if (fmt->uv_swapped) { > - tmp = u_off; > - u_off = v_off; > - v_off = tmp; The 'tmp' variable seems to be unused now, so its declaration should be removed. Thanks
diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c index aa1d4b6d278f..5f730cd6009d 100644 --- a/drivers/gpu/ipu-v3/ipu-image-convert.c +++ b/drivers/gpu/ipu-v3/ipu-image-convert.c @@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx, u_off = y_size - y_off + uv_off; v_off = (fmt->uv_packed) ? 0 : u_off + uv_size; - if (fmt->uv_swapped) { - tmp = u_off; - u_off = v_off; - v_off = tmp; - } + if (fmt->uv_swapped) + swap(u_off, v_off); image->tile[tile].offset = y_off; image->tile[tile].u_off = u_off;
Use swap() instead of implementing it since it makes code more clean. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)