diff mbox series

[v3,02/15] dt-bindings: mediatek: add vdosys1 MERGE definition for mt8195

Message ID 20210818091847.8060-3-nancy.lin@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add MediaTek SoC DRM (vdosys1) support for mt8195 | expand

Commit Message

Nancy Lin (林欣螢) Aug. 18, 2021, 9:18 a.m. UTC
Add vdosys1 MERGE definition.

Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,merge.yaml    | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chun-Kuang Hu Aug. 19, 2021, 11:25 p.m. UTC | #1
Hi, Nancy:

Nancy.Lin <nancy.lin@mediatek.com> 於 2021年8月18日 週三 下午5:18寫道:
>
> Add vdosys1 MERGE definition.
>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,merge.yaml    | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> index 1a27b037086b..ba1e0c837988 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> @@ -23,6 +23,8 @@ properties:
>            - const: mediatek,mt8173-disp-merge
>        - items:
>            - const: mediatek,mt8195-disp-merge
> +      - items:
> +          - const: mediatek,mt8195-vdo1-merge

I don't know why create a new merge for mt8195. Provide more
information about the difference of these two merge.

Regards,
Chun-Kuang.

>
>    reg:
>      maxItems: 1
> --
> 2.18.0
>
Nancy Lin (林欣螢) Aug. 24, 2021, 5:07 a.m. UTC | #2
Hi Chun-Kuang,

Thanks for the review.

On Fri, 2021-08-20 at 07:25 +0800, Chun-Kuang Hu wrote:
> Hi, Nancy:
> 
> Nancy.Lin <nancy.lin@mediatek.com> 於 2021年8月18日 週三 下午5:18寫道:
> > 
> > Add vdosys1 MERGE definition.
> > 
> > Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,merge.yaml    |
> > 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge
> > .yaml
> > index 1a27b037086b..ba1e0c837988 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge
> > .yaml
> > @@ -23,6 +23,8 @@ properties:
> >            - const: mediatek,mt8173-disp-merge
> >        - items:
> >            - const: mediatek,mt8195-disp-merge
> > +      - items:
> > +          - const: mediatek,mt8195-vdo1-merge
> 
> I don't know why create a new merge for mt8195. Provide more
> information about the difference of these two merge.
> 
Compared with MT8195 merge0 and merge5, merge1~4 has more mute
function. I will remove this new compatible, move ovl_adaptor merge to
merge common driver, and add new merge binding property to increase
mute function.

> Regards,
> Chun-Kuang.
> 
> > 
> >    reg:
> >      maxItems: 1
> > --
> > 2.18.0
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
index 1a27b037086b..ba1e0c837988 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
@@ -23,6 +23,8 @@  properties:
           - const: mediatek,mt8173-disp-merge
       - items:
           - const: mediatek,mt8195-disp-merge
+      - items:
+          - const: mediatek,mt8195-vdo1-merge
 
   reg:
     maxItems: 1