From patchwork Thu Aug 19 13:38:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12447267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359D5C4320A for ; Thu, 19 Aug 2021 13:38:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2919610FE for ; Thu, 19 Aug 2021 13:38:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2919610FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C2666E94E; Thu, 19 Aug 2021 13:38:43 +0000 (UTC) Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED4896E94E for ; Thu, 19 Aug 2021 13:38:41 +0000 (UTC) Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 445B63F33E; Thu, 19 Aug 2021 13:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1629380320; bh=uDY6JrKLk8FztgRxaD2qoQzFWUTC3bULwnHL6dWM7q0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=pKp4W5jJWQh7i2c+8UZYOJcyQWX8Z2yW81NoyiyYlmjK8k7J6w+s2mzAtAEnzQXSJ dKzfSeinMyIJ62VG2JLd0mU8pPueIY24igg97mds7yQTSqRosIrZaP+lheQBmZ7qeg ko4ZdjGl5GaAloudfYu1Jpz93mA1Gq9MtbGEZZxzj5XBwELXY1ghtVWny1NGvnFZr0 mvz6MBALFiBlCX2J+D0hAPXTdBP1WG1Mm6467lgCwzQcDIOcGcttxgpZ4jHBrOHETc jtTED9P0XY1MqmK8GVJWsLuYk1WNTf5OE2HT33thN3vHH1OTreYNpm+S0gBx5UdnCw L5y/DYYKjxuBw== From: Colin King To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller Date: Thu, 19 Aug 2021 14:38:39 +0100 Message-Id: <20210819133839.10745-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Colin Ian King Don't populate the array ext_div on the stack but instead it static const. Makes the object code smaller by 118 bytes: Before: text data bss dec hex filename 39449 17500 128 57077 def5 ./drivers/gpu/drm/bridge/tc358767.o After: text data bss dec hex filename 39235 17596 128 56959 de7f ./drivers/gpu/drm/bridge/tc358767.o (gcc version 10.3.0) Signed-off-by: Colin Ian King --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 23a6f90b694b..599c23759400 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -468,7 +468,7 @@ static int tc_pxl_pll_en(struct tc_data *tc, u32 refclk, u32 pixelclock) int div, best_div = 1; int mul, best_mul = 1; int delta, best_delta; - int ext_div[] = {1, 2, 3, 5, 7}; + static const int ext_div[] = {1, 2, 3, 5, 7}; int best_pixelclock = 0; int vco_hi = 0; u32 pxl_pllparam;