| Message ID | 20210827163956.27517-2-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/bridge: it66121: Initialize {device,vendor}_ids | expand |
On 27/08/2021 18:39, Paul Cercueil wrote: > If run before the next bridge is initialized, of_drm_find_bridge() will > give us a NULL pointer. > > If that's the case, return -EPROBE_DEFER; we may have more luck next > time. > Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver") > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index b130d01147c6..9dc41a7b9136 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -924,6 +924,9 @@ static int it66121_probe(struct i2c_client *client, > ctx->next_bridge = of_drm_find_bridge(ep); > of_node_put(ep); > > + if (!ctx->next_bridge) > + return -EPROBE_DEFER; > + > i2c_set_clientdata(client, ctx); > mutex_init(&ctx->lock); > > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> Thanks, Neil
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index b130d01147c6..9dc41a7b9136 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -924,6 +924,9 @@ static int it66121_probe(struct i2c_client *client, ctx->next_bridge = of_drm_find_bridge(ep); of_node_put(ep); + if (!ctx->next_bridge) + return -EPROBE_DEFER; + i2c_set_clientdata(client, ctx); mutex_init(&ctx->lock);
If run before the next bridge is initialized, of_drm_find_bridge() will give us a NULL pointer. If that's the case, return -EPROBE_DEFER; we may have more luck next time. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/gpu/drm/bridge/ite-it66121.c | 3 +++ 1 file changed, 3 insertions(+)