| Message ID | 20210905130501.32980-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: panel-orientation-quirks: Add quirk for the Chuwi HiBook | expand |
On Sun, Sep 05, 2021 at 03:05:01PM +0200, Hans de Goede wrote: > The Chuwi HiBook uses a panel which has been mounted > 90 degrees rotated. Add a quirk for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 ++++++++ > 1 file changed, 8 insertions(+) I'm not very familiar with these quirks, but this looks correct and inline with other entries in this table. > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > index 4e965b0f5502..7e0f581a360e 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -140,6 +140,14 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"), > }, > .driver_data = (void *)&lcd800x1280_rightside_up, > + }, { /* Chuwi HiBook (CWI514) */ > + .matches = { > + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > + /* Above matches are too generic, add bios-date match */ > + DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"), > + }, > + .driver_data = (void *)&lcd1200x1920_rightside_up, > }, { /* Chuwi Hi10 Pro (CWI529) */ > .matches = { > DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hampoo"), One thing I noticed is that there doesn't seem to be an entry for Chuwi Hi10 anywhere in linux-next. Perhaps that's from a different patch in your local tree, or it's based on some other tree that already has that. In any case, I trust that this can be resolved when applying, so this seems okay: Reviewed-by: Thierry Reding <treding@nvidia.com>
Hi, On 9/9/21 5:50 PM, Thierry Reding wrote: > On Sun, Sep 05, 2021 at 03:05:01PM +0200, Hans de Goede wrote: >> The Chuwi HiBook uses a panel which has been mounted >> 90 degrees rotated. Add a quirk for this. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > I'm not very familiar with these quirks, but this looks correct and > inline with other entries in this table. > >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> index 4e965b0f5502..7e0f581a360e 100644 >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> @@ -140,6 +140,14 @@ static const struct dmi_system_id orientation_data[] = { >> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"), >> }, >> .driver_data = (void *)&lcd800x1280_rightside_up, >> + }, { /* Chuwi HiBook (CWI514) */ >> + .matches = { >> + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), >> + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), >> + /* Above matches are too generic, add bios-date match */ >> + DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"), >> + }, >> + .driver_data = (void *)&lcd1200x1920_rightside_up, >> }, { /* Chuwi Hi10 Pro (CWI529) */ >> .matches = { >> DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > > One thing I noticed is that there doesn't seem to be an entry for Chuwi > Hi10 anywhere in linux-next. Perhaps that's from a different patch in > your local tree, or it's based on some other tree that already has that. It is based on drm-misc-next, which has a recent patch adding the Hi 10 Pro: https://cgit.freedesktop.org/drm-misc/commit/?id=072e70d52372c44df90b44fb4cd949a709bb5bef I guess this is not in linux-next yet because of the merge-window. > In any case, I trust that this can be resolved when applying, so this > seems okay: > > Reviewed-by: Thierry Reding <treding@nvidia.com> Thank you. Regards, Hans
Hi, On 9/9/21 5:50 PM, Thierry Reding wrote: > On Sun, Sep 05, 2021 at 03:05:01PM +0200, Hans de Goede wrote: >> The Chuwi HiBook uses a panel which has been mounted >> 90 degrees rotated. Add a quirk for this. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > I'm not very familiar with these quirks, but this looks correct and > inline with other entries in this table. > >> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> index 4e965b0f5502..7e0f581a360e 100644 >> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c >> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c >> @@ -140,6 +140,14 @@ static const struct dmi_system_id orientation_data[] = { >> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"), >> }, >> .driver_data = (void *)&lcd800x1280_rightside_up, >> + }, { /* Chuwi HiBook (CWI514) */ >> + .matches = { >> + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), >> + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), >> + /* Above matches are too generic, add bios-date match */ >> + DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"), >> + }, >> + .driver_data = (void *)&lcd1200x1920_rightside_up, >> }, { /* Chuwi Hi10 Pro (CWI529) */ >> .matches = { >> DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hampoo"), > > One thing I noticed is that there doesn't seem to be an entry for Chuwi > Hi10 anywhere in linux-next. Perhaps that's from a different patch in > your local tree, or it's based on some other tree that already has that. > In any case, I trust that this can be resolved when applying, so this > seems okay: > > Reviewed-by: Thierry Reding <treding@nvidia.com> Thank you, I've pushed this to drm-misc-next now. Regards, Hans
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 4e965b0f5502..7e0f581a360e 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -140,6 +140,14 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T103HAF"), }, .driver_data = (void *)&lcd800x1280_rightside_up, + }, { /* Chuwi HiBook (CWI514) */ + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"), + DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), + /* Above matches are too generic, add bios-date match */ + DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"), + }, + .driver_data = (void *)&lcd1200x1920_rightside_up, }, { /* Chuwi Hi10 Pro (CWI529) */ .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
The Chuwi HiBook uses a panel which has been mounted 90 degrees rotated. Add a quirk for this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+)