| Message ID | 20210906011210.80327-3-xinhui.pan@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm/ttm: Fix a deadlock if the target BO is not idle during swap | expand |
Am 06.09.21 um 03:12 schrieb xinhui pan: > Like vce/vcn does, visible VRAM is OK for ib test. > While commit a11d9ff3ebe0 ("drm/amdgpu: use GTT for > uvd_get_create/destory_msg") says VRAM is not mapped correctly in his > platform which is likely an arm64. > > So lets change back to use VRAM on x86_64 platform. That's still a rather clear NAK. This issue is not related to ARM at all and you are trying to fix a problem which is independent of the platform. Christian. > > Signed-off-by: xinhui pan <xinhui.pan@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > index d451c359606a..e4b75f33ccc8 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > @@ -1178,7 +1178,11 @@ int amdgpu_uvd_get_create_msg(struct amdgpu_ring *ring, uint32_t handle, > int r, i; > > r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE, > +#ifdef CONFIG_X86_64 > + AMDGPU_GEM_DOMAIN_VRAM, > +#else > AMDGPU_GEM_DOMAIN_GTT, > +#endif > &bo, NULL, (void **)&msg); > if (r) > return r; > @@ -1210,7 +1214,11 @@ int amdgpu_uvd_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, > int r, i; > > r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE, > +#ifdef CONFIG_X86_64 > + AMDGPU_GEM_DOMAIN_VRAM, > +#else > AMDGPU_GEM_DOMAIN_GTT, > +#endif > &bo, NULL, (void **)&msg); > if (r) > return r;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c index d451c359606a..e4b75f33ccc8 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c @@ -1178,7 +1178,11 @@ int amdgpu_uvd_get_create_msg(struct amdgpu_ring *ring, uint32_t handle, int r, i; r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE, +#ifdef CONFIG_X86_64 + AMDGPU_GEM_DOMAIN_VRAM, +#else AMDGPU_GEM_DOMAIN_GTT, +#endif &bo, NULL, (void **)&msg); if (r) return r; @@ -1210,7 +1214,11 @@ int amdgpu_uvd_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, int r, i; r = amdgpu_bo_create_reserved(adev, 1024, PAGE_SIZE, +#ifdef CONFIG_X86_64 + AMDGPU_GEM_DOMAIN_VRAM, +#else AMDGPU_GEM_DOMAIN_GTT, +#endif &bo, NULL, (void **)&msg); if (r) return r;
Like vce/vcn does, visible VRAM is OK for ib test. While commit a11d9ff3ebe0 ("drm/amdgpu: use GTT for uvd_get_create/destory_msg") says VRAM is not mapped correctly in his platform which is likely an arm64. So lets change back to use VRAM on x86_64 platform. Signed-off-by: xinhui pan <xinhui.pan@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 8 ++++++++ 1 file changed, 8 insertions(+)