From patchwork Fri Sep 24 15:26:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 12515713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D5C9C433FE for ; Fri, 24 Sep 2021 15:26:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8647610D1 for ; Fri, 24 Sep 2021 15:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E8647610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 073546E1D5; Fri, 24 Sep 2021 15:26:28 +0000 (UTC) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by gabe.freedesktop.org (Postfix) with ESMTPS id E724B6E1D2 for ; Fri, 24 Sep 2021 15:26:26 +0000 (UTC) Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 52556402DF for ; Fri, 24 Sep 2021 15:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632497185; bh=BJQ1tcf/UkpkN508ynAJCoG+ggl8X9aVGCS6hw5OEH0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Rt21dhzExhu4+UP+H8ni8+xlIZve3UVePPYd6S2dXYBx+E3lgNYKjUC/Ly6sp+5ys tp6kwemrl0gZ/TPqbBAZR7PwjUWkIQD8LjRLCibS82bgt6lTlu4pSkFzVQjb6tlodw v39HPN4ts59DEm6jdexIqQ+dYgy+PjjieL1wQgZLZ5NHFX4jcMy0niGMIidk8gRf+v 4vU++k7e2XfLnOrH+aWbvzlKCuuEx0c08DKxm5krWWATdYFecG28cr0RIdtXIytGrP BPoF5QGd1LzFIaq8B7o0jg2D0eR7FFy2z5ICjkarOR99EmjqI33cCQC/B10sLIKClu D3S7vg8Rv11yg== Received: by mail-pj1-f70.google.com with SMTP id c10-20020a17090ab28a00b0019ce70ee349so6302941pjr.7 for ; Fri, 24 Sep 2021 08:26:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BJQ1tcf/UkpkN508ynAJCoG+ggl8X9aVGCS6hw5OEH0=; b=vVCDRYCkiPFHR8Y7wnIdgeiBksgiZhBF5GV5hVyZ+okDsUtqVU8wBW1fXHkp1GK0eR gut5wLYjwTQ3i/5GvobK++dumo957CghfnA9NUC7GLAph8+Ff5wIxTBifbd54XbMhFfD ciidYkQbpWd9bL6l/DB9K0D4nt8irevk42KqGHJk+MaC9NeZ9p+itcIOdNu/lZEUMX13 TpQTMAN8M8e5zcDFxfPs7GxIVoDe+6jxGAN9ZZ6Mqo36P1od49DpHw/Fg2O0DJbyUzp3 MqlEox/IKbpP8uXrg/Ggjygs51BbrNpwKpxT9fz5JwhumI+uZKcrBPBs2o8SgtSXg5zb v2pw== X-Gm-Message-State: AOAM530rWBEDI0DaLhp6QwzRiwjPDlyLlYpvlHSehetnTgEb2xtAwG9s /rmWG1pvEHDj0Y2naMiKi3+BQu6hZzDHijA04izxr5GskOjXwpM595yd49och1yyDGSUdtt0MMH ACZv+VY1nDy4gXH4q95D6cU67LaQtlVvlNnFCjA5BnCOXuA== X-Received: by 2002:a17:902:76c3:b0:13c:957d:561f with SMTP id j3-20020a17090276c300b0013c957d561fmr9407116plt.27.1632497183548; Fri, 24 Sep 2021 08:26:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxE5/Uiux7+1UFrhzHCKhGu2VwGC7ehLwJsokzC6lOe3qr+QDJLo84y2if8gaO2xS6nvRF6pw== X-Received: by 2002:a17:902:76c3:b0:13c:957d:561f with SMTP id j3-20020a17090276c300b0013c957d561fmr9407087plt.27.1632497183286; Fri, 24 Sep 2021 08:26:23 -0700 (PDT) Received: from localhost.localdomain ([69.163.84.166]) by smtp.gmail.com with ESMTPSA id f16sm9190541pfk.110.2021.09.24.08.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 08:26:22 -0700 (PDT) From: Tim Gardner To: dri-devel@lists.freedesktop.org Cc: tim.gardner@canonical.com, William Breathitt Gray , Syed Nayyar Waris , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: parade-ps8640: check return values in ps8640_aux_transfer() Date: Fri, 24 Sep 2021 09:26:07 -0600 Message-Id: <20210924152607.28580-1-tim.gardner@canonical.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Coverity complains of an unused return code: CID 120459 (#1 of 1): Unchecked return value (CHECKED_RETURN) 7. check_return: Calling regmap_bulk_write without checking return value (as is done elsewhere 199 out of 291 times). 204 regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, 205 ARRAY_SIZE(addr_len)); While I was at it I noticed 2 other places where return codes were not being used, or used incorrectly (which is a real bug). Fix these errors by correctly using the returned error codes. Cc: William Breathitt Gray Cc: Syed Nayyar Waris Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Tim Gardner --- drivers/gpu/drm/bridge/parade-ps8640.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 3aaa90913bf8..591da962970a 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -201,8 +201,12 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, addr_len[PAGE0_SWAUX_LENGTH - base] = (len == 0) ? SWAUX_NO_PAYLOAD : ((len - 1) & SWAUX_LENGTH_MASK); - regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, + ret = regmap_bulk_write(map, PAGE0_SWAUX_ADDR_7_0, addr_len, ARRAY_SIZE(addr_len)); + if (ret) { + DRM_DEV_ERROR(dev, "failed to bulk write ADDR_7_0: %d\n", ret); + return ret; + } if (len && (request == DP_AUX_NATIVE_WRITE || request == DP_AUX_I2C_WRITE)) { @@ -218,13 +222,17 @@ static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, } } - regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); + ret = regmap_write(map, PAGE0_SWAUX_CTRL, SWAUX_SEND); + if (ret) { + DRM_DEV_ERROR(dev, "failed to write SEND: %d\n", ret); + return ret; + } /* Zero delay loop because i2c transactions are slow already */ regmap_read_poll_timeout(map, PAGE0_SWAUX_CTRL, data, !(data & SWAUX_SEND), 0, 50 * 1000); - regmap_read(map, PAGE0_SWAUX_STATUS, &data); + ret = regmap_read(map, PAGE0_SWAUX_STATUS, &data); if (ret) { DRM_DEV_ERROR(dev, "failed to read PAGE0_SWAUX_STATUS: %d\n", ret);