diff mbox series

[2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures

Message ID 20211011152106.3424810-3-thanneeru.srinivasulu@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/guc: Inject probe errors for MMIO send, CT send | expand

Commit Message

Thanneeru Srinivasulu Oct. 11, 2021, 3:21 p.m. UTC
Replace DRM_ERROR with i915_probe_error to report early HuC failures.

Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Matthew Brost Oct. 11, 2021, 6:13 p.m. UTC | #1
On Mon, Oct 11, 2021 at 08:51:04PM +0530, Thanneeru Srinivasulu wrote:
> Replace DRM_ERROR with i915_probe_error to report early HuC failures.
> 
> Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/i915/gt/uc/intel_huc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> index ff4b6869b80b..ff0f5b9130c9 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> @@ -179,7 +179,7 @@ int intel_huc_auth(struct intel_huc *huc)
>  	ret = intel_guc_auth_huc(guc,
>  				 intel_guc_ggtt_offset(guc, huc->rsa_data));
>  	if (ret) {
> -		DRM_ERROR("HuC: GuC did not ack Auth request %d\n", ret);
> +		i915_probe_error(gt->i915, "HuC: GuC did not ack Auth request %d\n", ret);
>  		goto fail;
>  	}
>  
> @@ -190,7 +190,7 @@ int intel_huc_auth(struct intel_huc *huc)
>  					huc->status.value,
>  					2, 50, NULL);
>  	if (ret) {
> -		DRM_ERROR("HuC: Firmware not verified %d\n", ret);
> +		i915_probe_error(gt->i915, "HuC: Firmware not verified %d\n", ret);
>  		goto fail;
>  	}
>  
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
index ff4b6869b80b..ff0f5b9130c9 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
@@ -179,7 +179,7 @@  int intel_huc_auth(struct intel_huc *huc)
 	ret = intel_guc_auth_huc(guc,
 				 intel_guc_ggtt_offset(guc, huc->rsa_data));
 	if (ret) {
-		DRM_ERROR("HuC: GuC did not ack Auth request %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: GuC did not ack Auth request %d\n", ret);
 		goto fail;
 	}
 
@@ -190,7 +190,7 @@  int intel_huc_auth(struct intel_huc *huc)
 					huc->status.value,
 					2, 50, NULL);
 	if (ret) {
-		DRM_ERROR("HuC: Firmware not verified %d\n", ret);
+		i915_probe_error(gt->i915, "HuC: Firmware not verified %d\n", ret);
 		goto fail;
 	}