From patchwork Mon Oct 18 03:04:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xin Ji X-Patchwork-Id: 12564905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C996AC433EF for ; Mon, 18 Oct 2021 03:04:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D23160F8F for ; Mon, 18 Oct 2021 03:04:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D23160F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=analogixsemi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B198D6E93A; Mon, 18 Oct 2021 03:04:16 +0000 (UTC) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2110.outbound.protection.outlook.com [40.107.94.110]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A30D6E93A for ; Mon, 18 Oct 2021 03:04:15 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnL1pwZW6M28s9i7YayOZg9bVeTy2/ueqn8ejb9GFSQo38bwSaM/1Ih6/xdqtf5K34WWHMOm4a/NnnL5z1fc64GOo9kQUgcQulnDgzSf2IW4j6iXUkbch7FXMRNW9hQV+qB/uJzdvPRcDb+uBdgLvYcmqiMqnbZIl2ookwKYqLxxX+g9nit4u4DG4Q6qSOs9Sw1yd5gt74RAmVXYLuajPcPwWZauolwRa89F1J91eL1pL28brNZDdJiipWNB1mN86zblkSjTWCtoAfaa/aTvfvceSrm741v/cidJys2WNQfwy3ZrtkgLfeMYKqwITywhJsojR5ubgHCn4JGeRkN6cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62WVvWzK+pB/K0a4jPqlwmMuNIxX++bTARPe39RkU/w=; b=c+/P6+QqcFmeKE+yDxgKq6kPuDWgrOXs7opMMgrcWftR//9/OHqt1u/oAY99D8j4V2uCrp9bWV+rgC/wGj+Ul7JY+k14JvOeoULnmKa5p9ySYxPLwQV1lUDEeP2GUsW1nZnwT2i7M28ikAA5jEt7/DqDR4XRpdv9KPXOlwQt50VszbgtHsVWVZnq9bmMvQrF59bW/mWPwTWaZrDXB2KSVKYWHIfxi4JJojEOVMrbsOtBfd5zREPkpRNQmYIXfd4/QEpadrhYx5I9RqUNlmN7kUB0WEayn0Zs/yRvba2oSHe95/7aRRewNed1m8Jzty1p3pW6N9+TD9mV+hkS3+YgRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=analogixsemi.com; dmarc=pass action=none header.from=analogixsemi.com; dkim=pass header.d=analogixsemi.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Analogixsemi.onmicrosoft.com; s=selector2-Analogixsemi-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62WVvWzK+pB/K0a4jPqlwmMuNIxX++bTARPe39RkU/w=; b=RUBehavzQOUymTm1cPDIjIBlbJvFW8206odvXg6X16uJ5o30i+3s3VpxxIjTQmSupOa3e0UyvO++zEsDOqi62UeIkeLRk3X2YdIZh6VENJjNfl14kaNXXNbzdxia11g+NiWo/sD89SS1lT/SdohNvpNi1XcJBEDAVH18RCT6nAA= Authentication-Results: analogixsemi.com; dkim=none (message not signed) header.d=none;analogixsemi.com; dmarc=none action=none header.from=analogixsemi.com; Received: from BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) by BYAPR04MB3862.namprd04.prod.outlook.com (2603:10b6:a02:ad::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Mon, 18 Oct 2021 03:04:13 +0000 Received: from BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::e149:c2d4:fd23:a682]) by BY5PR04MB6739.namprd04.prod.outlook.com ([fe80::e149:c2d4:fd23:a682%7]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 03:04:13 +0000 From: Xin Ji To: xji@analogixsemi.com Cc: Laurent.pinchart@ideasonboard.com, a.hajda@samsung.com, airlied@linux.ie, anarsoul@gmail.com, bliang@analogixsemi.com, boris.brezillon@collabora.com, dan.carpenter@oracle.com, daniel@ffwll.ch, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, drinkcat@google.com, duwe@lst.de, hsinyi@chromium.org, jonas@kwiboo.se, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, narmstrong@baylibre.com, robert.foss@linaro.org, sam@ravnborg.org, span@analogixsemi.com, zhenli@analogixsemi.com Subject: [PATCH v11 2/4] drm/bridge: anx7625: fix not correct return value Date: Mon, 18 Oct 2021 11:04:05 +0800 Message-Id: <20211018030405.2055161-1-xji@analogixsemi.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <14407ca8fd8627ebd41e6f37b22a8f4fae3fedc6.1628161369.git.xji@analogixsemi.com> References: <14407ca8fd8627ebd41e6f37b22a8f4fae3fedc6.1628161369.git.xji@analogixsemi.com> X-ClientProxiedBy: HK2PR04CA0084.apcprd04.prod.outlook.com (2603:1096:202:15::28) To BY5PR04MB6739.namprd04.prod.outlook.com (2603:10b6:a03:229::8) MIME-Version: 1.0 Received: from anxtwsw-Precision-3640-Tower (60.251.58.79) by HK2PR04CA0084.apcprd04.prod.outlook.com (2603:1096:202:15::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Mon, 18 Oct 2021 03:04:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e01a2a9b-b920-4b8f-70dd-08d991e3f67d X-MS-TrafficTypeDiagnostic: BYAPR04MB3862: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:813; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Gi0Bvl93xc82u5a+YskWna/wwLdkL4zdE1AM/GHdIbeOzo1OFXnX5UeKKK9ANKx/MWY62DPMVTfTAIKiese8HUK56L1r5AOOtHOdcuLE59WZPRxzh/apFuZn8HyHSs5E6NORrpJHU53SM7wPrBSmJVB1C+Y3fmVZlOBBt7/LgU/t+omHIv9Wtnz3y1kPM3mIxAh2VzDXd+tqPNhSlvMzI2FtxZKOTi7swEKyGpRv58RLo9vAtoB6ekEp2da720QbGd9UVc14OmxLzc4jU01Rgif5HmWO/K/eIBydzlH3xPouJ5yTfWKeDzQ58eWg9T6Qpi28S2fPuCqs5J/ye1gQUcRPylqbuDNi6r4rQes5/h4STSIphtZeVNe49c/O5GRfdsJNe/daUA87oDAu82JwsE2KatazBd3NPiKbAMcsQTGJF8T2E818UODlInzbPC6P/DLvH6MqrX+G96vKxynNWhWrbO2oo8csTHjxBBL/4XRdOYS1leekp7I2A0UGxZ8ekpCJ+dhlTurl++VepAb6h5akpi1ZD12dMZskAKTy4BOh1cu3xSBBKTs7mbUFn9p+OTENPxspKSbjNPMsqdZNwz2NSQB/xKZJcjGO1F+ZiBCLG53p/Y3TXK4blcI+D4393rmNfRXQAddIaVzUmNQeZ1PJg7Wcp9n6iTIUd96Ngs3MN8lzzxsbIS2/jv0L6TL3/TRqtBJui60lpZxttBE8A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR04MB6739.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(2906002)(38100700002)(186003)(6666004)(1076003)(34206002)(6496006)(55236004)(52116002)(107886003)(36756003)(2616005)(4744005)(956004)(26005)(8676002)(66946007)(6486002)(38350700002)(7416002)(5660300002)(4326008)(37006003)(86362001)(8936002)(508600001)(316002)(66556008)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 53zH5Go+zMRRiWRZTXqTKsLTeHm5rmwXABJlx2F+Z4He+K5BQg8ENXX/IOq5K26VsDS7+WLjbZ359m+CVaSGYe+cQF0Ddqwy7gDSHOGppDk/yYg+Wq+5YoTkRLF9hp0WpNyAwjaiDdzzBb+5m3rPftpVpr08gAA1j6OFNAkjyOjM8yUluCFrJ6jsJCpArbajbK84TX/B/aAHtZuYTAZjHRIE0yaB2WGzxbfTeNRQijWZgoPKHqRguVw+NRF+t8y2poPu7YJ0Ykjf9/EEGE9oJd8Www/5B4jiiFUWZdgjQ7PxTwsPj1kCegoe3NgwtjNKFTPgd6qDgAovDOJLAaOqvCzFntaWFRM3vrcuThyt2YcLAdqjApCwjPVUusIFu1JJSnpozFclezAgXhuXVTyH9sQQkxVrPl6TnyOC1MgfCCg0RAP8lUTH2fNxSak1OHLx5YDqQhF32RnpH9ov/qdrh33dLXvRSz93vPHxr5kTiCojFPfjyXf4eaUfzE1v6Z2aESvZ83+doscilcUiNzVOKnYtdjdxZWOv5MxPvx6BLtsQQy5GN2xfD8UqDcwj8hEZOr/Qfljx895Fv738igIYE5drodu88qVx2GQ1bKwh8Imwlk+Y1r4wnByiZNCEa4TRDGv2xusAqOZ6xpe0qsNgOrd40J1NUghWfVfiiwppFIUHDYBKoYLEFLGc3vYnFHJbPnhdgy+fT0vZ30Ke5a8u68pkJoVGpx/tneJ3ka+4YMm11al5iuuBSeMsom9IBxClCjY6CLugm9lVKvkpnOLFs8lou6SKVLTYu95Z73LDZkvNAkQJvj5MvzjxsGUE3WUjzOy0zfjH0NvhgrL5xpWG73o4dRkBbJfdmxB0T4oUSHO1nasyriw6bOY/GCPUWyq7aIYJuQaUuPgVZ4v4aoasctFLgiJazpiSJTxTCppWP3mZniywuZ+fixndlhRlC/dczs/BpiRsb2HwtT63TO1mvKeApaO2JXIcpt8WaLI3zp/TQf8LLxqroWV+FkpNQIfLWrelE6tRCb7oXOGLvxfnTfXLMKvHVcbqzxlbFUC15WoG0kW+/XFk3rl/32ts45+d73tV4aCwUCNnRWaBkmW5F8g3Ggi9+TXAUuIZL4ihwix4T8xd/648x7AI206zxUKtOXKGBXAlmEe0J7fYHOpKEqUYMZYYd9VdptRqmtfUQsaP+c/wjGBXstBdoXWlGd9k0ijiuDOqgNgjqPPFc/6Qt4NMoqmppKCHEfcHEVO0lO0NWlS4HxvUvhtH/jPRG5vf3yjhl+p/CkK8EIRhGERorfACWYFe1NrLrITEGbGSA7w9DAJaJRmAKx0TFhZ+Fgn3 X-OriginatorOrg: analogixsemi.com X-MS-Exchange-CrossTenant-Network-Message-Id: e01a2a9b-b920-4b8f-70dd-08d991e3f67d X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 03:04:13.3056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q7v65VM9+vzkJE0Zbtjo4spEbbsBmP2q412VljS15194PJw3/MmGgNzNlmjx8Wc3/yKrQYc80wVTFap17bRC0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3862 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" At some time, the original code may return non zero value, force return 0 if operation finished. Reviewed-by: Robert Foss Signed-off-by: Xin Ji --- drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 1a871f6b6822..469037f2fd3d 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -191,10 +191,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) AP_AUX_CTRL_STATUS); if (val < 0 || (val & 0x0F)) { DRM_DEV_ERROR(dev, "aux status %02x\n", val); - val = -EIO; + return -EIO; } - return val; + return 0; } static int anx7625_video_mute_control(struct anx7625_data *ctx,