| Message ID | 20211108121544.776590-7-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Cleanups for the nomodeset kernel command line parameter logic | expand |
Hi Am 08.11.21 um 13:15 schrieb Javier Martinez Canillas: > The message printed when nomodeset is present in the kernel command line > makes it look as if the parameter must never be used and it's a bad idea. > > But there are valid reasons to use this parameter and the message should > not imply otherwise. Change the text to be more accurate and restrained. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > (no changes since v1) > > drivers/gpu/drm/drm_nomodeset.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git drivers/gpu/drm/drm_nomodeset.c drivers/gpu/drm/drm_nomodeset.c > index fc3acf3ab2e2..45e50b3497b8 100644 > --- drivers/gpu/drm/drm_nomodeset.c > +++ drivers/gpu/drm/drm_nomodeset.c > @@ -15,9 +15,7 @@ static int __init disable_modeset(char *str) > { > drm_nomodeset = true; > > - pr_warn("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); > - pr_warn("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); > - pr_warn("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); > + pr_warn("Booted with the nomodeset parameter. Graphics drivers will not be loaded\n"); Same issue as with patch 5. Rather say something like Booted with the nomodeset parameter. Only the system framebuffer will be available. Best regards Thomas > > return 1; > } >
diff --git drivers/gpu/drm/drm_nomodeset.c drivers/gpu/drm/drm_nomodeset.c index fc3acf3ab2e2..45e50b3497b8 100644 --- drivers/gpu/drm/drm_nomodeset.c +++ drivers/gpu/drm/drm_nomodeset.c @@ -15,9 +15,7 @@ static int __init disable_modeset(char *str) { drm_nomodeset = true; - pr_warn("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); - pr_warn("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); - pr_warn("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); + pr_warn("Booted with the nomodeset parameter. Graphics drivers will not be loaded\n"); return 1; }
The message printed when nomodeset is present in the kernel command line makes it look as if the parameter must never be used and it's a bad idea. But there are valid reasons to use this parameter and the message should not imply otherwise. Change the text to be more accurate and restrained. Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- (no changes since v1) drivers/gpu/drm/drm_nomodeset.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)