| Message ID | 20211124145219.GD13656@kili (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: anx7625: fix an error code in anx7625_register_audio() | expand |
On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote: > This code accidentally returns IS_ERR(), which is 1, instead of > propagating the negative error code. The caller doesn't check for > errors so it doesn't affect run time at all. > > Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
On Thu, 25 Nov 2021 at 09:16, Tzung-Bi Shih <tzungbi@google.com> wrote: > > On Wed, Nov 24, 2021 at 05:52:19PM +0300, Dan Carpenter wrote: > > This code accidentally returns IS_ERR(), which is 1, instead of > > propagating the negative error code. The caller doesn't check for > > errors so it doesn't affect run time at all. > > > > Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> Applied to drm-misc-next.
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 001fb39d9919..f56e106b445d 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx) sizeof(codec_data)); if (IS_ERR(ctx->audio_pdev)) - return IS_ERR(ctx->audio_pdev); + return PTR_ERR(ctx->audio_pdev); DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);
This code accidentally returns IS_ERR(), which is 1, instead of propagating the negative error code. The caller doesn't check for errors so it doesn't affect run time at all. Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)