diff mbox series

agp: parisc-agp: fix section mismatch warning

Message ID 20211127045757.27908-1-rdunlap@infradead.org (mailing list archive)
State New, archived
Headers show
Series agp: parisc-agp: fix section mismatch warning | expand

Commit Message

Randy Dunlap Nov. 27, 2021, 4:57 a.m. UTC
Fix section mismatch warning in parisc-agp:

WARNING: modpost: drivers/char/agp/parisc-agp.o(.text+0x7a0): Section mismatch in reference from the function init_module() to the function .init.text:parisc_agp_setup.isra.0()
The function init_module() references
the function __init parisc_agp_setup.isra.0().
This is often because init_module lacks a __init 
annotation or the annotation of parisc_agp_setup.isra.0 is wrong.

Fixes: 08a6436816f7 ("[PARISC] Add support for Quicksilver AGPGART")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: David Airlie <airlied@linux.ie>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org
---
 drivers/char/agp/parisc-agp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rolf Eike Beer Nov. 27, 2021, 10:56 a.m. UTC | #1
Am Samstag, 27. November 2021, 05:57:57 CET schrieb Randy Dunlap:
> Fix section mismatch warning in parisc-agp:

Too late ;)

https://lore.kernel.org/linux-parisc/20211126154754.263487-1-deller@gmx.de/
Helge Deller Nov. 27, 2021, 11:14 a.m. UTC | #2
On 11/27/21 11:56, Rolf Eike Beer wrote:
> Am Samstag, 27. November 2021, 05:57:57 CET schrieb Randy Dunlap:
>> Fix section mismatch warning in parisc-agp:

Thanks Randy!

> Too late ;)
>
> https://lore.kernel.org/linux-parisc/20211126154754.263487-1-deller@gmx.de/

Being late doesn't matter!
I'm really happy about all patches which are sent in for parisc and in the past
often I applied the late-sent-in patches instead of mine, simply because the
commit message was much better than mine.

So, patches are always welcome.

Helge
diff mbox series

Patch

--- linux-next-20211126.orig/drivers/char/agp/parisc-agp.c
+++ linux-next-20211126/drivers/char/agp/parisc-agp.c
@@ -378,7 +378,7 @@  find_quicksilver(struct device *dev, voi
 	return 0;
 }
 
-static int
+static int __init
 parisc_agp_init(void)
 {
 	extern struct sba_device *sba_list;