| Message ID | 20211207072943.121961-4-marcan@marcan.st (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/simpledrm: Apple M1 / DT platform support fixes | expand |
Hi Am 07.12.21 um 08:29 schrieb Hector Martin: > This is the format used by the bootloader framebuffer on Apple ARM64 > platforms. > > Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > drivers/gpu/drm/tiny/simpledrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c > index 2f999915b9aa..edadfd9ee882 100644 > --- a/drivers/gpu/drm/tiny/simpledrm.c > +++ b/drivers/gpu/drm/tiny/simpledrm.c > @@ -571,7 +571,7 @@ static const uint32_t simpledrm_default_formats[] = { > //DRM_FORMAT_XRGB1555, > //DRM_FORMAT_ARGB1555, > DRM_FORMAT_RGB888, > - //DRM_FORMAT_XRGB2101010, > + DRM_FORMAT_XRGB2101010, > //DRM_FORMAT_ARGB2101010, You should also enable DRM_FORMAT_ARGB2101010 here. You added the conversion function, so DRM can deal with it. Having an alpha channel isn't typically supported for primary planes, but the format is listed in SIMPLEFB_FORMATS. [1] With this change: Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards [1] https://elixir.bootlin.com/linux/latest/source/include/linux/platform_data/simplefb.h#L16 > }; > >
diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 2f999915b9aa..edadfd9ee882 100644 --- a/drivers/gpu/drm/tiny/simpledrm.c +++ b/drivers/gpu/drm/tiny/simpledrm.c @@ -571,7 +571,7 @@ static const uint32_t simpledrm_default_formats[] = { //DRM_FORMAT_XRGB1555, //DRM_FORMAT_ARGB1555, DRM_FORMAT_RGB888, - //DRM_FORMAT_XRGB2101010, + DRM_FORMAT_XRGB2101010, //DRM_FORMAT_ARGB2101010, };