| Message ID | 20211215010008.2545520-60-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drm: Make all drivers to honour the nomodeset parameter | expand |
Hi, Javier! On 15.12.21 03:00, Javier Martinez Canillas wrote: > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the systewm system framebuffer will be available if it was set-up. s/systewm system/system > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > drivers/gpu/drm/xen/xen_drm_front.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c > index 434064c820e8..20d11ea79e0f 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front.c > +++ b/drivers/gpu/drm/xen/xen_drm_front.c > @@ -495,6 +495,9 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) > struct drm_device *drm_dev; > int ret; > > + if (drm_firmware_drivers_only()) This is not yet in the upstream kernel, right? > + return -ENODEV; > + > DRM_INFO("Creating %s\n", xen_drm_driver.desc); > > drm_info = kzalloc(sizeof(*drm_info), GFP_KERNEL); With the commit message fixed: Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Thank you, Oleksandr
Hello Oleksandr, On 12/15/21 06:58, Oleksandr Andrushchenko wrote: > Hi, Javier! > > On 15.12.21 03:00, Javier Martinez Canillas wrote: >> According to disable Documentation/admin-guide/kernel-parameters.txt, this >> parameter can be used to disable kernel modesetting. >> >> DRM drivers will not perform display-mode changes or accelerated rendering >> and only the systewm system framebuffer will be available if it was set-up. > s/systewm system/system >> Thanks a lot for spotting this! I rewrote the commit message a couple of times and didn't notice that ended with a sentence that was mangled. Best regards,
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 434064c820e8..20d11ea79e0f 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -495,6 +495,9 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info) struct drm_device *drm_dev; int ret; + if (drm_firmware_drivers_only()) + return -ENODEV; + DRM_INFO("Creating %s\n", xen_drm_driver.desc); drm_info = kzalloc(sizeof(*drm_info), GFP_KERNEL);
According to disable Documentation/admin-guide/kernel-parameters.txt, this parameter can be used to disable kernel modesetting. DRM drivers will not perform display-mode changes or accelerated rendering and only the systewm system framebuffer will be available if it was set-up. But only a few DRM drivers currently check for nomodeset, make this driver to also support the command line parameter. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- drivers/gpu/drm/xen/xen_drm_front.c | 3 +++ 1 file changed, 3 insertions(+)