| Message ID | 20211222090552.25972-7-jose.exposito89@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add missing format_mod_supported functions | expand |
Hello José, thanks for your patch. Reviewed-by: Yannick Fertre <yannick.fertre@foss.st.com> Tested-by: Yannick Fertre <yannick.fertre@foss.st.com> On 12/22/21 10:05 AM, José Expósito wrote: > The "drm_plane_funcs.format_mod_supported" can be removed in favor of > the default implementation. > > Signed-off-by: José Expósito <jose.exposito89@gmail.com> > --- > drivers/gpu/drm/stm/ltdc.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index dbdee954692a..ef909e50f0e4 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct drm_printer *p, > fpsi->counter = 0; > } > > -static bool ltdc_plane_format_mod_supported(struct drm_plane *plane, > - u32 format, > - u64 modifier) > -{ > - if (modifier == DRM_FORMAT_MOD_LINEAR) > - return true; > - > - return false; > -} > - > static const struct drm_plane_funcs ltdc_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > @@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = { > .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, > .atomic_print_state = ltdc_plane_atomic_print_state, > - .format_mod_supported = ltdc_plane_format_mod_supported, > }; > > static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = { >
On Wed, Dec 22, 2021 at 2:36 PM José Expósito <jose.exposito89@gmail.com> wrote: > > The "drm_plane_funcs.format_mod_supported" can be removed in favor of > the default implementation. > > Signed-off-by: José Expósito <jose.exposito89@gmail.com> > --- Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> Tested-by: Jagan Teki <jagan@amarulasolutions.com> # i.Core STM32MP1
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index dbdee954692a..ef909e50f0e4 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -925,16 +925,6 @@ static void ltdc_plane_atomic_print_state(struct drm_printer *p, fpsi->counter = 0; } -static bool ltdc_plane_format_mod_supported(struct drm_plane *plane, - u32 format, - u64 modifier) -{ - if (modifier == DRM_FORMAT_MOD_LINEAR) - return true; - - return false; -} - static const struct drm_plane_funcs ltdc_plane_funcs = { .update_plane = drm_atomic_helper_update_plane, .disable_plane = drm_atomic_helper_disable_plane, @@ -943,7 +933,6 @@ static const struct drm_plane_funcs ltdc_plane_funcs = { .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, .atomic_destroy_state = drm_atomic_helper_plane_destroy_state, .atomic_print_state = ltdc_plane_atomic_print_state, - .format_mod_supported = ltdc_plane_format_mod_supported, }; static const struct drm_plane_helper_funcs ltdc_plane_helper_funcs = {
The "drm_plane_funcs.format_mod_supported" can be removed in favor of the default implementation. Signed-off-by: José Expósito <jose.exposito89@gmail.com> --- drivers/gpu/drm/stm/ltdc.c | 11 ----------- 1 file changed, 11 deletions(-)