| Message ID | 20220114064012.1670612-1-ddavenport@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: bridge: it66121: Remove redundant check | expand |
On 14/01/2022 07:40, Drew Davenport wrote: > ctx->next_bridge is checked for NULL twice in a row. The second > conditional is redundant, so remove it. > > Signed-off-by: Drew Davenport <ddavenport@chromium.org> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 06b59b422c69..69288cf894b9 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client, > return -EPROBE_DEFER; > } > > - if (!ctx->next_bridge) > - return -EPROBE_DEFER; > - > i2c_set_clientdata(client, ctx); > mutex_init(&ctx->lock); > > Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Hi, On Thu, 13 Jan 2022 23:40:12 -0700, Drew Davenport wrote: > ctx->next_bridge is checked for NULL twice in a row. The second > conditional is redundant, so remove it. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: bridge: it66121: Remove redundant check https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1500296576464dd4f8f7ba409069591648f4e98c
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 06b59b422c69..69288cf894b9 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -936,9 +936,6 @@ static int it66121_probe(struct i2c_client *client, return -EPROBE_DEFER; } - if (!ctx->next_bridge) - return -EPROBE_DEFER; - i2c_set_clientdata(client, ctx); mutex_init(&ctx->lock);
ctx->next_bridge is checked for NULL twice in a row. The second conditional is redundant, so remove it. Signed-off-by: Drew Davenport <ddavenport@chromium.org> --- drivers/gpu/drm/bridge/ite-it66121.c | 3 --- 1 file changed, 3 deletions(-)