diff mbox series

drm/udl: Return correct error code on kmalloc failure

Message ID 20220115164525.50258-1-harshit.m.mogalapalli@oracle.com (mailing list archive)
State New, archived
Headers show
Series drm/udl: Return correct error code on kmalloc failure | expand

Commit Message

Harshit Mogalapalli Jan. 15, 2022, 4:45 p.m. UTC
-ENOMEM is correct error code to return on a memory allocation failure
instead of -1.

Smatch Warning:
drivers/gpu/drm/udl/udl_connector.c:27 udl_get_edid_block() warn:
returning -1 instead of -ENOMEM is sloppy

Fixes: a51143001d9e ("drm/udl: Refactor edid retrieving in UDL driver (v2)")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
 drivers/gpu/drm/udl/udl_connector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
index 930574ad2bca..b7a9c6d103ba 100644
--- a/drivers/gpu/drm/udl/udl_connector.c
+++ b/drivers/gpu/drm/udl/udl_connector.c
@@ -24,7 +24,7 @@  static int udl_get_edid_block(void *data, u8 *buf, unsigned int block,
 
 	read_buff = kmalloc(2, GFP_KERNEL);
 	if (!read_buff)
-		return -1;
+		return -ENOMEM;
 
 	for (i = 0; i < len; i++) {
 		int bval = (i + block * EDID_LENGTH) << 8;