| Message ID | 20220123204322.345725-1-luca@z3ntu.xyz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: add missing dependency to DRM_PANEL_EDP | expand |
On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation > fails: > > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' > > Add a dependency on DRM_KMS_HELPER to fix this. > Forgot to add, this is the closest "Fixes" I can find, before that commit with arm32 qcom_defconfig both beforementioned options were builtin Fixes: 9d6366e743f3 ("drm: fb_helper: improve CONFIG_FB dependency") > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > I briefly tried "select DRM_KMS_HELPER" but that causes a circular > dependency. > If someone has a better idea how to solve this, feel free correct me. > > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 434c2861bb40..fda97837ecb3 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE > config DRM_PANEL_EDP > tristate "support for simple Embedded DisplayPort panels" > depends on OF > + depends on DRM_KMS_HELPER > depends on BACKLIGHT_CLASS_DEVICE > depends on PM > select VIDEOMODE_HELPERS
Hi, any feedback on this patch? On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation > fails: > > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' > > Add a dependency on DRM_KMS_HELPER to fix this. > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- > I briefly tried "select DRM_KMS_HELPER" but that causes a circular > dependency. > If someone has a better idea how to solve this, feel free correct me. > > drivers/gpu/drm/panel/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 434c2861bb40..fda97837ecb3 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE > config DRM_PANEL_EDP > tristate "support for simple Embedded DisplayPort panels" > depends on OF > + depends on DRM_KMS_HELPER > depends on BACKLIGHT_CLASS_DEVICE > depends on PM > select VIDEOMODE_HELPERS
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 434c2861bb40..fda97837ecb3 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE config DRM_PANEL_EDP tristate "support for simple Embedded DisplayPort panels" depends on OF + depends on DRM_KMS_HELPER depends on BACKLIGHT_CLASS_DEVICE depends on PM select VIDEOMODE_HELPERS
With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation fails: drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to `drm_panel_dp_aux_backlight' Add a dependency on DRM_KMS_HELPER to fix this. Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- I briefly tried "select DRM_KMS_HELPER" but that causes a circular dependency. If someone has a better idea how to solve this, feel free correct me. drivers/gpu/drm/panel/Kconfig | 1 + 1 file changed, 1 insertion(+)