| Message ID | 20220123223417.6244-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/imx: make static read-only array channel_offsets const | expand |
On So, 2022-01-23 at 22:34 +0000, Colin Ian King wrote: > The static array channel_offsets is read-only so it make sense to > make > it const. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu- > dc.c > index ca96b235491a..b038a6d7307b 100644 > --- a/drivers/gpu/ipu-v3/ipu-dc.c > +++ b/drivers/gpu/ipu-v3/ipu-dc.c > @@ -344,8 +344,9 @@ int ipu_dc_init(struct ipu_soc *ipu, struct > device *dev, > unsigned long base, unsigned long template_base) > { > struct ipu_dc_priv *priv; > - static int channel_offsets[] = { 0, 0x1c, 0x38, 0x54, 0x58, > 0x5c, > - 0x78, 0, 0x94, 0xb4}; > + static const int channel_offsets[] = { > + 0, 0x1c, 0x38, 0x54, 0x58, 0x5c, 0x78, 0, 0x94, 0xb4 > + }; > int i; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); Thank you, applied to imx-drm/next. regards Philipp
diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c index ca96b235491a..b038a6d7307b 100644 --- a/drivers/gpu/ipu-v3/ipu-dc.c +++ b/drivers/gpu/ipu-v3/ipu-dc.c @@ -344,8 +344,9 @@ int ipu_dc_init(struct ipu_soc *ipu, struct device *dev, unsigned long base, unsigned long template_base) { struct ipu_dc_priv *priv; - static int channel_offsets[] = { 0, 0x1c, 0x38, 0x54, 0x58, 0x5c, - 0x78, 0, 0x94, 0xb4}; + static const int channel_offsets[] = { + 0, 0x1c, 0x38, 0x54, 0x58, 0x5c, 0x78, 0, 0x94, 0xb4 + }; int i; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
The static array channel_offsets is read-only so it make sense to make it const. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/ipu-v3/ipu-dc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)