| Message ID | 20220131201537.2325487-1-javierm@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drm/tiny: Add driver for Solomon SSD1307 OLED displays | expand |
Hi Javier, On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: > To make sure that tools like the get_maintainer.pl script will suggest > to Cc me if patches are posted for this driver. > > Also include the Device Tree binding for the old ssd1307fb fbdev driver > since the new DRM driver was made compatible with the existing binding. To avoid any confusion add yourself as Maintainer in the solomon,ssd1307fb.yaml file too. With that done: Acked-by: Sam Ravnborg <sam@ravnborg.org> > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d03ad8da1f36..2e6c3aad5d71 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6102,6 +6102,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/repaper.txt > F: drivers/gpu/drm/tiny/repaper.c > > +DRM DRIVER FOR SOLOMON SSD1307 OLED DISPLAYS > +M: Javier Martinez Canillas <javierm@redhat.com> > +S: Maintained > +T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > +F: drivers/gpu/drm/tiny/ssd1307.c > + > DRM DRIVER FOR QEMU'S CIRRUS DEVICE > M: Dave Airlie <airlied@redhat.com> > M: Gerd Hoffmann <kraxel@redhat.com> > -- > 2.34.1
Hello Sam, Thanks a lot for your feedback. On 1/31/22 21:46, Sam Ravnborg wrote: > Hi Javier, > > On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: >> To make sure that tools like the get_maintainer.pl script will suggest >> to Cc me if patches are posted for this driver. >> >> Also include the Device Tree binding for the old ssd1307fb fbdev driver >> since the new DRM driver was made compatible with the existing binding. > > To avoid any confusion add yourself as Maintainer in the > solomon,ssd1307fb.yaml file too. > Agreed. You mentioned in another email though to diverge from the existing DT binding for ssd1307fb. If we decide to keep the backward compatibility then I'll add another patch to the set to list myself as a co-maintainer. > With that done: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > Thanks! Best regards,
On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: > To make sure that tools like the get_maintainer.pl script will suggest > to Cc me if patches are posted for this driver. > > Also include the Device Tree binding for the old ssd1307fb fbdev driver > since the new DRM driver was made compatible with the existing binding. Dunno why you have patches 3 and 4 missed references (in terms of email thread). > +DRM DRIVER FOR SOLOMON SSD1307 OLED DISPLAYS > +M: Javier Martinez Canillas <javierm@redhat.com> > +S: Maintained > +T: git git://anongit.freedesktop.org/drm/drm-misc > +F: Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > +F: drivers/gpu/drm/tiny/ssd1307.c I think it makes sense to add ssd1307fb as well. At least you may point out people patching old driver about new one until it's gone completely.
Hello Andy, On 2/1/22 10:32, Andy Shevchenko wrote: > On Mon, Jan 31, 2022 at 09:15:37PM +0100, Javier Martinez Canillas wrote: >> To make sure that tools like the get_maintainer.pl script will suggest >> to Cc me if patches are posted for this driver. >> >> Also include the Device Tree binding for the old ssd1307fb fbdev driver >> since the new DRM driver was made compatible with the existing binding. > > Dunno why you have patches 3 and 4 missed references (in terms of email > thread). > Yeah, I use the patman tool [0] to post patches and something went wrong after sending the first patch and I had to manually post the others with git-send-email. I could had used --in-reply-to, but didn't feel like it. [0]: https://gitlab.com/u-boot/u-boot/tree/master/tools/patman >> +DRM DRIVER FOR SOLOMON SSD1307 OLED DISPLAYS >> +M: Javier Martinez Canillas <javierm@redhat.com> >> +S: Maintained >> +T: git git://anongit.freedesktop.org/drm/drm-misc >> +F: Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml >> +F: drivers/gpu/drm/tiny/ssd1307.c > > I think it makes sense to add ssd1307fb as well. At least you may point out > people patching old driver about new one until it's gone completely. > That's a good idea. I also found some issues in the ssd1307fb driver when doing the port, so I could dig more to fix them and propose myself as a co-maintainer for the fbdev driver. But I'll do that as a separate patch-set. Best regards,
diff --git a/MAINTAINERS b/MAINTAINERS index d03ad8da1f36..2e6c3aad5d71 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6102,6 +6102,13 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/repaper.txt F: drivers/gpu/drm/tiny/repaper.c +DRM DRIVER FOR SOLOMON SSD1307 OLED DISPLAYS +M: Javier Martinez Canillas <javierm@redhat.com> +S: Maintained +T: git git://anongit.freedesktop.org/drm/drm-misc +F: Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +F: drivers/gpu/drm/tiny/ssd1307.c + DRM DRIVER FOR QEMU'S CIRRUS DEVICE M: Dave Airlie <airlied@redhat.com> M: Gerd Hoffmann <kraxel@redhat.com>
To make sure that tools like the get_maintainer.pl script will suggest to Cc me if patches are posted for this driver. Also include the Device Tree binding for the old ssd1307fb fbdev driver since the new DRM driver was made compatible with the existing binding. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)