| Message ID | 20220202081755.145716-2-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mxsfb fixes | expand |
On 2/2/22 09:17, Alexander Stein wrote: > Use the dev_err_probe() helper, instead of open-coding the same > operation. This also adds a nice hint in > /sys/kernel/debug/devices_deferred. > > Reviewed-by: Marek Vasut <marex@denx.de> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) V2: ... what changed ... ? (probably nothing, since the patch still looks fine)
Am Mittwoch, 2. Februar 2022, 09:29:20 CET schrieb Marek Vasut: > On 2/2/22 09:17, Alexander Stein wrote: > > Use the dev_err_probe() helper, instead of open-coding the same > > operation. This also adds a nice hint in > > /sys/kernel/debug/devices_deferred. > > > > Reviewed-by: Marek Vasut <marex@denx.de> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > V2: ... what changed ... ? > > (probably nothing, since the patch still looks fine) I put the changelog into cover letter (0/2). Content hasn't changed, I just added your Reviewed-by. Regards, Alexander
On 2/2/22 09:58, Alexander Stein wrote: > Am Mittwoch, 2. Februar 2022, 09:29:20 CET schrieb Marek Vasut: >> On 2/2/22 09:17, Alexander Stein wrote: >>> Use the dev_err_probe() helper, instead of open-coding the same >>> operation. This also adds a nice hint in >>> /sys/kernel/debug/devices_deferred. >>> >>> Reviewed-by: Marek Vasut <marex@denx.de> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>> --- >>> >>> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> V2: ... what changed ... ? >> >> (probably nothing, since the patch still looks fine) > > I put the changelog into cover letter (0/2). Content hasn't changed, I just > added your Reviewed-by. I missed it in the cover letter, got it.
On 2/2/22 10:03, Marek Vasut wrote: > On 2/2/22 09:58, Alexander Stein wrote: >> Am Mittwoch, 2. Februar 2022, 09:29:20 CET schrieb Marek Vasut: >>> On 2/2/22 09:17, Alexander Stein wrote: >>>> Use the dev_err_probe() helper, instead of open-coding the same >>>> operation. This also adds a nice hint in >>>> /sys/kernel/debug/devices_deferred. >>>> >>>> Reviewed-by: Marek Vasut <marex@denx.de> >>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >>>> --- >>>> >>>> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> V2: ... what changed ... ? >>> >>> (probably nothing, since the patch still looks fine) >> >> I put the changelog into cover letter (0/2). Content hasn't changed, I >> just >> added your Reviewed-by. > > I missed it in the cover letter, got it. Applied to drm-misc/drm-misc-next , thanks.
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 375f26d4a417..c4da358f2154 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -258,8 +258,7 @@ static int mxsfb_load(struct drm_device *drm, ret = mxsfb_attach_bridge(mxsfb); if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(drm->dev, "Cannot connect bridge: %d\n", ret); + dev_err_probe(drm->dev, ret, "Cannot connect bridge\n"); goto err_vblank; }