From patchwork Thu Feb 3 07:13:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 12733846 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF078C433F5 for ; Thu, 3 Feb 2022 07:13:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D88E110EAF9; Thu, 3 Feb 2022 07:13:30 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E23E310EAF9 for ; Thu, 3 Feb 2022 07:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643872409; x=1675408409; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=X7ghyglDa70r3RhXc5kH04RplSTIl9G4nspSQejw+hs=; b=WOybl1WMwJLgXzkte/YzCXHD3xKHRXb2jmT4sICXUNyq3YM+AcpulhGS hJ2gizqthygkFmIzrNCIxzBreMG/2ovkGc4ND3+Xnmc4qGWilyC3lzHNT 9q79OpmIT0A5iEFtYbIWhVEbHNdLiTLmE6FCseGvAnW5TblP5RK/fxvTh tfCb1P1+Dij5Q/MlJEG1PkqKwjcuSJDGhulH56zAFJYJSxr77699g1//s xQhu6oMnpaGpjES3t6idms9aRae92paWLhPlSmbf0xnYLEBL4pcm5tACh IzbspnEbrYeBA1xOzc2fSU2Ji+Ug0qnzgyKoq/iEduxFMndByWuM1MFYN Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="228056997" X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="228056997" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 23:13:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="523792340" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.151]) by orsmga007.jf.intel.com with SMTP; 02 Feb 2022 23:13:26 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 03 Feb 2022 09:13:26 +0200 From: Ville Syrjala To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/modes: Fix drm_mode_validate_size() docs Date: Thu, 3 Feb 2022 09:13:26 +0200 Message-Id: <20220203071326.23681-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Ville Syrjälä drm_mode_validate_size() does *not* modify the passed in mode's status (in fact it is passed in as const). Also this operates on a single mode, so the reference to some list is just confusing. Remove the nonsense docs. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 1c72208d8133..425a56a976a1 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c @@ -1136,16 +1136,14 @@ EXPORT_SYMBOL(drm_mode_validate_driver); /** * drm_mode_validate_size - make sure modes adhere to size constraints * @mode: mode to check * @maxX: maximum width * @maxY: maximum height * - * This function is a helper which can be used to validate modes against size - * limitations of the DRM device/connector. If a mode is too big its status - * member is updated with the appropriate validation failure code. The list - * itself is not changed. + * This function is a helper which can be used to validate + * modes against size limitations of the DRM device/connector. * * Returns: * The mode status */ enum drm_mode_status drm_mode_validate_size(const struct drm_display_mode *mode,