| Message ID | 20220207113307.346281-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/privacy-screen: Fix sphinx warning | expand |
Reviewed-by: Simon Ser <contact@emersion.fr>
Hi Simon,
On 2/7/22 12:37, Simon Ser wrote:
> Reviewed-by: Simon Ser <contact@emersion.fr>
Thank you, I also have this very similar patch pennding (also a simple htmldocs warning fix).
Any chance you can also review this one? :
https://patchwork.freedesktop.org/patch/470957/
Regards,
Hans
In case it matters... On Mon, Feb 7, 2022 at 3:33 AM Hans de Goede <hdegoede@redhat.com> wrote: > > Fix the following warning from "make htmldocs": > > drivers/gpu/drm/drm_privacy_screen.c:392: > warning: Function parameter or member 'data' not described in > 'drm_privacy_screen_register' > > Fixes: 30598d925d46 ("drm/privacy_screen: Add drvdata in drm_privacy_screen") > Cc: Rajat Jain <rajatja@google.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Rajat Jain <rajatja@google.com> Thanks Hans for taking care of this for me. Best Regards, Rajat > --- > drivers/gpu/drm/drm_privacy_screen.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_privacy_screen.c b/drivers/gpu/drm/drm_privacy_screen.c > index 03b149cc455b..45c080134488 100644 > --- a/drivers/gpu/drm/drm_privacy_screen.c > +++ b/drivers/gpu/drm/drm_privacy_screen.c > @@ -379,6 +379,7 @@ static void drm_privacy_screen_device_release(struct device *dev) > * drm_privacy_screen_register - register a privacy-screen > * @parent: parent-device for the privacy-screen > * @ops: &struct drm_privacy_screen_ops pointer with ops for the privacy-screen > + * @data: Private data owned by the privacy screen provider > * > * Create and register a privacy-screen. > * > -- > 2.33.1 >
diff --git a/drivers/gpu/drm/drm_privacy_screen.c b/drivers/gpu/drm/drm_privacy_screen.c index 03b149cc455b..45c080134488 100644 --- a/drivers/gpu/drm/drm_privacy_screen.c +++ b/drivers/gpu/drm/drm_privacy_screen.c @@ -379,6 +379,7 @@ static void drm_privacy_screen_device_release(struct device *dev) * drm_privacy_screen_register - register a privacy-screen * @parent: parent-device for the privacy-screen * @ops: &struct drm_privacy_screen_ops pointer with ops for the privacy-screen + * @data: Private data owned by the privacy screen provider * * Create and register a privacy-screen. *
Fix the following warning from "make htmldocs": drivers/gpu/drm/drm_privacy_screen.c:392: warning: Function parameter or member 'data' not described in 'drm_privacy_screen_register' Fixes: 30598d925d46 ("drm/privacy_screen: Add drvdata in drm_privacy_screen") Cc: Rajat Jain <rajatja@google.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/drm_privacy_screen.c | 1 + 1 file changed, 1 insertion(+)