From patchwork Thu Feb 17 00:25:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12749190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B246DC433EF for ; Thu, 17 Feb 2022 00:26:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 97A5710E6A0; Thu, 17 Feb 2022 00:26:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D93B10E68D for ; Thu, 17 Feb 2022 00:25:56 +0000 (UTC) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C6C4F82148; Thu, 17 Feb 2022 01:25:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1645057555; bh=bqToU5+PbxYVzrJXIvQWF0mHiqZzYWa1q7R1M9IYA+c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IMPl/ffz493ELNcY9YF9jOhholkNORB0WXEBkX/UxG4jLTlmRlh0JpYvM/vfag8Nb G3aI83AurjnsF4asFVFzAEV1bgH5OLoN0Tb8KYz+wAJQ4i7HRNFUolK1zQnkUkGAdt 7K0Z3nJYdGuOc4JdnYdbs5CrLGOlZzy/f4B3NzOkIGVnskzTvku9C8wsBDQY7A4Nlp LAk4nQtZACyXyVCsgj7QJPqrbsspo2C2G/gU2RGgfvGMQ9taingLnZT25/P5xgDrYO HWWYBPVVxi1MEyXzCOkhr3VMNWqKOXwuYY2Xm/v2ciCyYJmwD5c/CMwnJBghlyy7D8 /KCBXrAeRfH+w== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH V2 06/12] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Date: Thu, 17 Feb 2022 01:25:24 +0100 Message-Id: <20220217002530.396563-7-marex@denx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220217002530.396563-1-marex@denx.de> References: <20220217002530.396563-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Robert Foss , Jagan Teki , Thomas Zimmermann , Sam Ravnborg , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DSI burst mode is more energy efficient than the DSI sync pulse mode, make use of the burst mode since the chip supports it as well. Disable the generation of EoT packet, the chip ignores it, so no point in emitting it. Enable transmission of data in LP mode, otherwise register read via DSI does not work with this chip. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Thomas Zimmermann To: dri-devel@lists.freedesktop.org Acked-by: Maxime Ripard --- V2: Rebase on next-20220214 --- drivers/gpu/drm/bridge/chipone-icn6211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 7cc1f0d0dcdfd..2040596717139 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -485,7 +485,8 @@ static int chipone_probe(struct mipi_dsi_device *dsi) dsi->lanes = icn->dsi_lanes; dsi->format = MIPI_DSI_FMT_RGB888; - dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE; + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; ret = mipi_dsi_attach(dsi); if (ret < 0) {