diff mbox series

[v1,1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

Message ID 20220221095312.3692669-1-o.rempel@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series [v1,1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum | expand

Commit Message

Oleksij Rempel Feb. 21, 2022, 9:53 a.m. UTC
From: David Jander <david@protonic.nl>

Recover default behavior of the device and set maximal brightness

Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
 arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Shawn Guo April 6, 2022, 1:23 a.m. UTC | #1
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Recover default behavior of the device and set maximal brightness
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
>  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
> index 227c952543d4..e6134efbfabd 100644
> --- a/arch/arm/boot/dts/imx6dl-victgo.dts
> +++ b/arch/arm/boot/dts/imx6dl-victgo.dts
> @@ -28,7 +28,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;

Please take a look at the documentation of the property.

  default-brightness-level:
    description:
      The default brightness level (index into the array defined by the
      "brightness-levels" property).

Shawn

>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> index 1ac7e13249d2..c1d06bc28c67 100644
> --- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
> @@ -23,7 +23,7 @@ backlight: backlight {
>  		pwms = <&pwm1 0 5000000 0>;
>  		brightness-levels = <0 16 64 255>;
>  		num-interpolated-steps = <16>;
> -		default-brightness-level = <1>;
> +		default-brightness-level = <48>;
>  		power-supply = <&reg_3v3>;
>  		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>  	};
> -- 
> 2.30.2
>
Shawn Guo April 6, 2022, 1:59 a.m. UTC | #2
On Wed, Apr 6, 2022 at 9:23 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> > From: David Jander <david@protonic.nl>
> >
> > Recover default behavior of the device and set maximal brightness
> >
> > Signed-off-by: David Jander <david@protonic.nl>
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx6dl-victgo.dts   | 2 +-
> >  arch/arm/boot/dts/imx6qdl-vicut1.dtsi | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
> > index 227c952543d4..e6134efbfabd 100644
> > --- a/arch/arm/boot/dts/imx6dl-victgo.dts
> > +++ b/arch/arm/boot/dts/imx6dl-victgo.dts
> > @@ -28,7 +28,7 @@ backlight: backlight {
> >               pwms = <&pwm1 0 5000000 0>;
> >               brightness-levels = <0 16 64 255>;
> >               num-interpolated-steps = <16>;
> > -             default-brightness-level = <1>;
> > +             default-brightness-level = <48>;
>
> Please take a look at the documentation of the property.
>
>   default-brightness-level:
>     description:
>       The default brightness level (index into the array defined by the
>       "brightness-levels" property).

Ah, never mind, I missed 'num-interpolated-steps' there.

Shawn
Shawn Guo April 6, 2022, 2:14 a.m. UTC | #3
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote:
> From: David Jander <david@protonic.nl>
> 
> Recover default behavior of the device and set maximal brightness
> 
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6dl-victgo.dts b/arch/arm/boot/dts/imx6dl-victgo.dts
index 227c952543d4..e6134efbfabd 100644
--- a/arch/arm/boot/dts/imx6dl-victgo.dts
+++ b/arch/arm/boot/dts/imx6dl-victgo.dts
@@ -28,7 +28,7 @@  backlight: backlight {
 		pwms = <&pwm1 0 5000000 0>;
 		brightness-levels = <0 16 64 255>;
 		num-interpolated-steps = <16>;
-		default-brightness-level = <1>;
+		default-brightness-level = <48>;
 		power-supply = <&reg_3v3>;
 		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
 	};
diff --git a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
index 1ac7e13249d2..c1d06bc28c67 100644
--- a/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-vicut1.dtsi
@@ -23,7 +23,7 @@  backlight: backlight {
 		pwms = <&pwm1 0 5000000 0>;
 		brightness-levels = <0 16 64 255>;
 		num-interpolated-steps = <16>;
-		default-brightness-level = <1>;
+		default-brightness-level = <48>;
 		power-supply = <&reg_3v3>;
 		enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
 	};