From patchwork Tue Feb 22 06:22:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 12754578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E5B4C433F5 for ; Tue, 22 Feb 2022 06:23:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAB6C10EF57; Tue, 22 Feb 2022 06:23:06 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 045F410EF2C for ; Tue, 22 Feb 2022 06:22:51 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id j7so22756662lfu.6 for ; Mon, 21 Feb 2022 22:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DcGm7ltYqskU4cKmyhujRtdVm6Wd95PkL411GLVzEg0=; b=ZOeIhdUl8aEQPWT0Lk9FhpAJNeRoEsOodBzDBZaHbHToDTJmeN5zGVJgRaaIuoTeP1 hW2jr0//5VYifyiU0rPvnZWxkHVaBwP/WvgoPxMrdKPr7OZkr2LPDFvQbQne0XiDjzkH F7gT2Ex3L5oo79xqxF0ZY3LWXRMJqAkT5Bkmt3nsesc5PuSjDGRwucZjBH/SseFximdy Ttx8Yo+2TdyBoTqzRcQfAF3s01M/21IwMZR1OrFZ8u51915StsSAxT0T7bNpAqEHGUot RRol0OqhsCsVM4Wj9jfB3xZ6LgB1hRaCaS/J9yn6WkWETMuUI2iT1O/HNpcr4Vjz2zKH xP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DcGm7ltYqskU4cKmyhujRtdVm6Wd95PkL411GLVzEg0=; b=T9hrhqyJTEkLG+mw+ro/P9AX+nwLlooe18GkSdQy49mmh7L4ZpF4/opG4qKXYXk/o1 y/ZnRcXFi+l2ITVhDtDDG2FAjUoJTmQiBXzDznzPColP3c7UhQPbZKQNS5aqlL11exHI Ja4P1tEgmJ60h4ZLu3UHe4Gi7zuKaXPrM+8o94ivaIyDcI1C3zv2xaImnh5ZsP0MmlfI ZBieP0bIa8QDqGh/OqVhGMHCo9jaBBGHepeIsHCcL2dBkM37fnWq4FfuWJlxfYc79pOP CtUkELHYQzoysHBc9br9mSzDdhtX7PFHQVQO6Ut3FeS6cAvtjMh1lhRLfrpC6Yg+UGNi uP0g== X-Gm-Message-State: AOAM533XoDaAmMOT+n9M9/Cq9Xhx9ncR8b+5whmEf1mWRoGSG2x0kcQ3 ayk5VkXyv7lNS0FbEpUnHnTHwg== X-Google-Smtp-Source: ABdhPJxTYyeAI3bxfHUqpTJltww19s0ePSzjABjzhBFX/t8IlsbAws1ZEMsucgUuFV1yeXo8ppEmgg== X-Received: by 2002:ac2:4a65:0:b0:443:7f84:5e08 with SMTP id q5-20020ac24a65000000b004437f845e08mr16481610lfp.336.1645510969232; Mon, 21 Feb 2022 22:22:49 -0800 (PST) Received: from eriador.lumag.spb.ru ([188.162.65.160]) by smtp.gmail.com with ESMTPSA id j24sm1216245lfb.59.2022.02.21.22.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:22:48 -0800 (PST) From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Subject: [PATCH 1/4] drm/msm/dpu: document INTF_EDP/INTF_DP difference Date: Tue, 22 Feb 2022 09:22:43 +0300 Message-Id: <20220222062246.242577-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> References: <20220222062246.242577-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Based on the discussions on the mailing list, document enum dpu_intf_type and it's controversial fields: INTF_DP and INTF_EDP. INTF_EDP is used for older eDP interface found on msm8x74/msm8x84 INTF_DP is used for both eDP and DP interfaces handled by the msm/dp driver. The DPU driver does not make a difference between them. Signed-off-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h index bb9ceadeb0bb..4f8336cc7911 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h @@ -205,12 +205,20 @@ enum dpu_intf { INTF_MAX }; +/* + * Historically these values correspond to the values written to the + * DISP_INTF_SEL register, which had to programmed manually. On newer MDP + * generations this register is NOP, but we keep the values for historical + * reasons. + */ enum dpu_intf_type { INTF_NONE = 0x0, INTF_DSI = 0x1, INTF_HDMI = 0x3, INTF_LCDC = 0x5, + /* old eDP found on 8x74 and 8x84 */ INTF_EDP = 0x9, + /* both DP and eDP, handled by the new DP driver */ INTF_DP = 0xa, INTF_TYPE_MAX,