| Message ID | 20220222131701.356117-6-maira.canal@usp.br (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix multiple compilation warnings | expand |
Applied. Thanks! Alex On Tue, Feb 22, 2022 at 8:18 AM Maíra Canal <maira.canal@usp.br> wrote: > > Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the > codebase. > > This was pointed by clang with the following warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5: > warning: no previous prototype for function > 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes] > int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int > requested_phyclk_khz) > ^ > > Signed-off-by: Maíra Canal <maira.canal@usp.br> > --- > .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > index b7f9e1b34c11..fd6497fd2dc5 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc > return actual_dispclk_set_mhz * 1000; > } > > -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) > -{ > - int actual_phypclk_set_mhz = -1; > - > - if (!clk_mgr->smu_present && requested_phyclk_khz) > - return requested_phyclk_khz; > - > - /* Unit of SMU msg parameter is Mhz */ > - actual_phypclk_set_mhz = dcn316_smu_send_msg_with_param( > - clk_mgr, > - VBIOSSMC_MSG_SetPhyclkVoltageByFreq, > - khz_to_mhz_ceil(requested_phyclk_khz)); > - > - return actual_phypclk_set_mhz * 1000; > -} > - > int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int requested_dcfclk_khz) > { > int actual_dcfclk_set_mhz = -1; > -- > 2.35.1 >
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c index b7f9e1b34c11..fd6497fd2dc5 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc return actual_dispclk_set_mhz * 1000; } -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) -{ - int actual_phypclk_set_mhz = -1; - - if (!clk_mgr->smu_present && requested_phyclk_khz) - return requested_phyclk_khz; - - /* Unit of SMU msg parameter is Mhz */ - actual_phypclk_set_mhz = dcn316_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetPhyclkVoltageByFreq, - khz_to_mhz_ceil(requested_phyclk_khz)); - - return actual_phypclk_set_mhz * 1000; -} - int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int requested_dcfclk_khz) { int actual_dcfclk_set_mhz = -1;
Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the codebase. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5: warning: no previous prototype for function 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes] int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) ^ Signed-off-by: Maíra Canal <maira.canal@usp.br> --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16 ---------------- 1 file changed, 16 deletions(-)