From patchwork Wed Mar 2 15:24:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Rusin X-Patchwork-Id: 12766227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5FF5C433FE for ; Wed, 2 Mar 2022 15:25:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB22710E32F; Wed, 2 Mar 2022 15:24:51 +0000 (UTC) Received: from letterbox.kde.org (letterbox.kde.org [IPv6:2001:41c9:1:41e::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 609F010E11D for ; Wed, 2 Mar 2022 15:24:45 +0000 (UTC) Received: from vertex.localdomain (pool-108-36-85-85.phlapa.fios.verizon.net [108.36.85.85]) (Authenticated sender: zack) by letterbox.kde.org (Postfix) with ESMTPSA id 7317C2872A2; Wed, 2 Mar 2022 15:24:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kde.org; s=users; t=1646234684; bh=4F+X8uCueyglrdMPtpqYPHzWxJyIY+coz153bAv64Es=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cRZ1Ib/2xpoqWMfsHeACmcfrl93ooVNYLBgZe1p5jWgOhz9LR0La+Rkzyl/zMARRx mg1UT+E4sXAey+hHPej9OL2MQS2xX81H264DAWG2G5xPYx4KvPnyLg7VoDZSoSp0Ot PmuQofqJ9KqnvIDjBmnXv2MCZK54v76Y1SUXChL7m7C+WlDeknEF4jIMl5IVhPqgEM +kay10V2UqM8+yDFAHibEYNgBtooWIe0fXLbR6v6lZlfCf1AaoTQheongo4rZ0I2F7 PUJ8rwpfiXVYIcRrT0Z3yb5HHs+LRcg4SVsmTa6tMLUfUgcQwnL9U/p0rBeaVxRYYo +HZlBuLaxGjoA== From: Zack Rusin To: dri-devel@lists.freedesktop.org Subject: [PATCH 6/8] drm/vmwgfx: Initialize drm_mode_fb_cmd2 Date: Wed, 2 Mar 2022 10:24:24 -0500 Message-Id: <20220302152426.885214-7-zack@kde.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220302152426.885214-1-zack@kde.org> References: <20220302152426.885214-1-zack@kde.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zack Rusin Cc: krastevm@vmware.com, stable@vger.kernel.org, mombasawalam@vmware.com, Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Zack Rusin Transition to drm_mode_fb_cmd2 from drm_mode_fb_cmd left the structure unitialized. drm_mode_fb_cmd2 adds a few additional members, e.g. flags and modifiers which were never initialized. Garbage in those members can cause random failures during the bringup of the fbcon. Initializing the structure fixes random blank screens after bootup due to flags/modifiers mismatches during the fbcon bring up. Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") Signed-off-by: Zack Rusin Cc: Daniel Vetter Cc: # v4.10+ Reviewed-by: Martin Krastev Reviewed-by: Maaz Mombasawala --- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index 8ee34576c7d0..adf17c740656 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c @@ -483,7 +483,7 @@ static int vmw_fb_kms_detach(struct vmw_fb_par *par, static int vmw_fb_kms_framebuffer(struct fb_info *info) { - struct drm_mode_fb_cmd2 mode_cmd; + struct drm_mode_fb_cmd2 mode_cmd = {0}; struct vmw_fb_par *par = info->par; struct fb_var_screeninfo *var = &info->var; struct drm_framebuffer *cur_fb;