| Message ID | 20220302175309.1098827-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm: ssd130x: remove redundant initialization of pointer mode | expand |
Hello Colin, Thanks for the patch. On Wed, Mar 2, 2022 at 6:53 PM Colin Ian King <colin.i.king@gmail.com> wrote: > > Pointer mode is being assigned a value that is never read, it is > being re-assigned later with a new value. The initialization is > redundant and can be removed. > Indeed. Acked-by: Javier Martinez Canillas <javierm@redhat.com> Best regards, Javier
On 3/2/22 19:29, Javier Martinez Canillas wrote: > Hello Colin, > > Thanks for the patch. > > On Wed, Mar 2, 2022 at 6:53 PM Colin Ian King <colin.i.king@gmail.com> wrote: >> >> Pointer mode is being assigned a value that is never read, it is >> being re-assigned later with a new value. The initialization is >> redundant and can be removed. >> > > Indeed. > > Acked-by: Javier Martinez Canillas <javierm@redhat.com> > Pushed to drm-misc-next (with fixed drm/ssd130x subject prefix). Thanks! -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 92c1902f53e4..ce4dc20412e0 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -579,7 +579,7 @@ static const struct drm_simple_display_pipe_funcs ssd130x_pipe_funcs = { static int ssd130x_connector_get_modes(struct drm_connector *connector) { struct ssd130x_device *ssd130x = drm_to_ssd130x(connector->dev); - struct drm_display_mode *mode = &ssd130x->mode; + struct drm_display_mode *mode; struct device *dev = ssd130x->dev; mode = drm_mode_duplicate(connector->dev, &ssd130x->mode);
Pointer mode is being assigned a value that is never read, it is being re-assigned later with a new value. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/solomon/ssd130x.c:582:27: warning: Value stored to 'mode' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)