| Message ID | 20220307125458.GA16710@kili (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/selftests: missing error code in igt_buddy_alloc_smoke() | expand |
Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com> On 07/03/22 6:24 pm, Dan Carpenter wrote: > Set the error code to -ENOMEM if drm_random_order() fails. > > Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c > index fa997f89522b..6eba590afa9b 100644 > --- a/drivers/gpu/drm/selftests/test-drm_buddy.c > +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c > @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) > } > > order = drm_random_order(mm.max_order + 1, &prng); > - if (!order) > + if (!order) { > + err = -ENOMEM; > goto out_fini; > + } > > for (i = 0; i <= mm.max_order; ++i) { > struct drm_buddy_block *block; >
Pushed to drm-misc-next. Just one nit below. Am 07.03.22 um 15:54 schrieb Arunpravin: > Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com> Some people are picky about using the full name here. And you I think we should volunteer you for maintaining that stuff :) So you might want to get commit rights for drm-misc-next as well. Christian. > > On 07/03/22 6:24 pm, Dan Carpenter wrote: >> Set the error code to -ENOMEM if drm_random_order() fails. >> >> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> --- >> drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c >> index fa997f89522b..6eba590afa9b 100644 >> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c >> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c >> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) >> } >> >> order = drm_random_order(mm.max_order + 1, &prng); >> - if (!order) >> + if (!order) { >> + err = -ENOMEM; >> goto out_fini; >> + } >> >> for (i = 0; i <= mm.max_order; ++i) { >> struct drm_buddy_block *block; >>
On Mon, Mar 07, 2022 at 05:14:59PM +0100, Christian König wrote: > Pushed to drm-misc-next. Just one nit below. > > Am 07.03.22 um 15:54 schrieb Arunpravin: > > Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam@amd.com> > > Some people are picky about using the full name here. > Signed-off-by is like signing a legal document to say that you have not stolen anyone else's copyrighted works (SCO lawsuit). So it should be whatever name you use to sign legal documents. regards, dan carpenter
diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c index fa997f89522b..6eba590afa9b 100644 --- a/drivers/gpu/drm/selftests/test-drm_buddy.c +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) } order = drm_random_order(mm.max_order + 1, &prng); - if (!order) + if (!order) { + err = -ENOMEM; goto out_fini; + } for (i = 0; i <= mm.max_order; ++i) { struct drm_buddy_block *block;
Set the error code to -ENOMEM if drm_random_order() fails. Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)