From patchwork Fri Mar 18 18:47:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12785789 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 647FFC433F5 for ; Fri, 18 Mar 2022 18:48:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 39D1110E70B; Fri, 18 Mar 2022 18:48:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id B26DD10E33A for ; Fri, 18 Mar 2022 18:48:16 +0000 (UTC) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BA8A183025; Fri, 18 Mar 2022 19:48:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1647629295; bh=MO7rpDjZb8qRc5LO6tC8BH89Xjf6A0Je3/5I7DRpxOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nZojhpVSAUW8tfqEs3R1j+Sa3xJ5oJ6QruTUeGvReFeNv4NPBAoZUYRoh32wYeI0P gxz/SSg30i0mmnrNJiiaxETKKbFLsAwex6wi6Zon6uoTGbSoTLXMEAqoN/nv3ALtx/ dopSQzmyNLSxoOvCQ36DiaFvC8L/KWMWShXdUwok+wmJBEkwXVXQkxTuiLG0jnnPT/ w0YMsVrh1ITNHo3upogbXr1g1KrUV2cyRGiB4KywCVyA8lGOcJWTODKA86uo/1PEgB pOCk2jnoXbpXKV91LVRZzjN1K01VSVuhkgEOwJC+ucIPaqs0XEer5LzVuxD5hxfcbl PylFIITWiqA8g== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH v5 05/11] drm: bridge: icn6211: Use DSI burst mode without EoT and with LP command mode Date: Fri, 18 Mar 2022 19:47:49 +0100 Message-Id: <20220318184755.113152-6-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220318184755.113152-1-marex@denx.de> References: <20220318184755.113152-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Robert Foss , Maxime Ripard , Thomas Zimmermann , Sam Ravnborg , Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The DSI burst mode is more energy efficient than the DSI sync pulse mode, make use of the burst mode since the chip supports it as well. Disable the generation of EoT packet, the chip ignores it, so no point in emitting it. Enable transmission of data in LP mode, otherwise register read via DSI does not work with this chip. Acked-by: Maxime Ripard Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc: Thomas Zimmermann To: dri-devel@lists.freedesktop.org --- V2: Rebase on next-20220214 V3: Add AB from Maxime V4: No change V5: No change --- drivers/gpu/drm/bridge/chipone-icn6211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index d4a52176814ce..e3a7b945a0ef5 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -464,7 +464,8 @@ static int chipone_probe(struct mipi_dsi_device *dsi) dsi->lanes = 4; dsi->format = MIPI_DSI_FMT_RGB888; - dsi->mode_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE; + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | + MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; ret = mipi_dsi_attach(dsi); if (ret < 0) {