From patchwork Fri Apr 1 16:37:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12798498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2623C433EF for ; Fri, 1 Apr 2022 16:38:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C02B010E1E2; Fri, 1 Apr 2022 16:38:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id C07BB10E152 for ; Fri, 1 Apr 2022 16:38:20 +0000 (UTC) Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 03F6884198; Fri, 1 Apr 2022 18:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1648831099; bh=ryF4sSVCN4xDNmiRgk+WutxWax/YEB5T15DxI47nwGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=auJ9GjOXNWyM7OFfoXoByaVt3XKjCAG2ErK0xvIOPkKtpUenMh6ANTlJagu1decMf Hkp5yl3nr4ZsF2TTTUbbYE+9UFrc82Y6qbnfWw7qcOVJ5QmbY6Tuw+ndOXp9pWjF2A VMnFx8DI3DOmDtVRK5aj4DxCEsYDlKYHytA3I3cbN9JoL4ZxuQh9W2jbL2SSBhjlUu 3SVm5gGgWXtscTvnCnthI7sRKi2KSu4kPJIvheXK9hcjjgXihdg9NJTNP4VFU7TB7r R3AHyZyXnPMLx+lxie4JnLjAaAZbju4vg+yy+wYILJ7VIaF5pFE8UUXoLn8dkXs6Pb bnLJrKaWPb7NQ== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [RFC][PATCH 3/3] drm/panel: lvds: Drop duplicate width-mm/height-mm check Date: Fri, 1 Apr 2022 18:37:55 +0200 Message-Id: <20220401163755.302548-3-marex@denx.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220401163755.302548-1-marex@denx.de> References: <20220401163755.302548-1-marex@denx.de> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Christoph Niedermaier , devicetree@vger.kernel.org, Daniel Vetter , robert.foss@linaro.org, Rob Herring , =?utf-8?q?Noralf_?= =?utf-8?q?Tr=C3=B8nnes?= , Laurent Pinchart , Thomas Zimmermann , Dmitry Osipenko , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The of_get_drm_panel_display_mode() now does check for presence of width-mm/height-mm DT properties, drop the duplicate check here. Signed-off-by: Marek Vasut Cc: Christoph Niedermaier Cc: Daniel Vetter Cc: Dmitry Osipenko Cc: Laurent Pinchart Cc: Noralf Trønnes Cc: Rob Herring Cc: Robert Foss Cc: Sam Ravnborg Cc: Thomas Zimmermann Cc: devicetree@vger.kernel.org To: dri-devel@lists.freedesktop.org Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/panel/panel-lvds.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c index eca067e78579..f11252fb00fe 100644 --- a/drivers/gpu/drm/panel/panel-lvds.c +++ b/drivers/gpu/drm/panel/panel-lvds.c @@ -128,18 +128,6 @@ static int panel_lvds_parse_dt(struct panel_lvds *lvds) return ret; } - if (lvds->dmode.width_mm == 0) { - dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n", - np, "width-mm"); - return -ENODEV; - } - - if (lvds->dmode.height_mm == 0) { - dev_err(lvds->dev, "%pOF: invalid or missing %s DT property\n", - np, "height-mm"); - return -ENODEV; - } - of_property_read_string(np, "label", &lvds->label); ret = drm_of_lvds_get_data_mapping(np);