| Message ID | 20220425130050.1643103-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/nouveau/disp/gv100: make gv100_disp_wimm static | expand |
Reviewed-by: Lyude Paul <lyude@redhat.com> Will push upstream in a moment On Mon, 2022-04-25 at 09:00 -0400, Tom Rix wrote: > Sparse reports this issue > wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should > it be static? > > This variable is only used in wimmgv100.c. Single file variables should be > static. > So use static as its storage-class specifier. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c > b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c > index 89d783368b4f..bb4db6351ddf 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c > @@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en) > nvkm_mask(device, 0x611da8, mask, data); > } > > -const struct nv50_disp_chan_func > +static const struct nv50_disp_chan_func > gv100_disp_wimm = { > .init = gv100_disp_dmac_init, > .fini = gv100_disp_dmac_fini,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c index 89d783368b4f..bb4db6351ddf 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c @@ -35,7 +35,7 @@ gv100_disp_wimm_intr(struct nv50_disp_chan *chan, bool en) nvkm_mask(device, 0x611da8, mask, data); } -const struct nv50_disp_chan_func +static const struct nv50_disp_chan_func gv100_disp_wimm = { .init = gv100_disp_dmac_init, .fini = gv100_disp_dmac_fini,
Sparse reports this issue wimmgv100.c:39:1: warning: symbol 'gv100_disp_wimm' was not declared. Should it be static? This variable is only used in wimmgv100.c. Single file variables should be static. So use static as its storage-class specifier. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)