| Message ID | 20220528160353.157870-4-konrad.dybcio@somainline.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/4] drm/msm/adreno: Remove dead code | expand |
On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote: > Leading spaces are not something checkpatch likes, and it says so when > they are present. Use tabs consistently to indent function body and > unwrap a 83-char-long line, as 100 is cool nowadays. unassociated trivia: > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h [] > @@ -199,7 +199,7 @@ static inline int adreno_is_a420(struct adreno_gpu *gpu) > > static inline int adreno_is_a430(struct adreno_gpu *gpu) > { > - return gpu->revn == 430; > + return gpu->revn == 430; > } looks like these could/should return bool > static inline int adreno_is_a506(struct adreno_gpu *gpu) > @@ -239,7 +239,7 @@ static inline int adreno_is_a540(struct adreno_gpu *gpu) > > static inline int adreno_is_a618(struct adreno_gpu *gpu) > { > - return gpu->revn == 618; > + return gpu->revn == 618; > } etc...
On 5/28/2022 10:22 PM, Joe Perches wrote: > On Sat, 2022-05-28 at 18:03 +0200, Konrad Dybcio wrote: >> Leading spaces are not something checkpatch likes, and it says so when >> they are present. Use tabs consistently to indent function body and >> unwrap a 83-char-long line, as 100 is cool nowadays. > unassociated trivia: > >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > [] >> @@ -199,7 +199,7 @@ static inline int adreno_is_a420(struct adreno_gpu *gpu) >> >> static inline int adreno_is_a430(struct adreno_gpu *gpu) >> { >> - return gpu->revn == 430; >> + return gpu->revn == 430; >> } > looks like these could/should return bool But this is just a format fix. > >> static inline int adreno_is_a506(struct adreno_gpu *gpu) >> @@ -239,7 +239,7 @@ static inline int adreno_is_a540(struct adreno_gpu *gpu) >> >> static inline int adreno_is_a618(struct adreno_gpu *gpu) >> { >> - return gpu->revn == 618; >> + return gpu->revn == 618; >> } > etc... Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com> -Akhil.
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h index a13a3e5a294b..f73f7b5dfd10 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -199,7 +199,7 @@ static inline int adreno_is_a420(struct adreno_gpu *gpu) static inline int adreno_is_a430(struct adreno_gpu *gpu) { - return gpu->revn == 430; + return gpu->revn == 430; } static inline int adreno_is_a506(struct adreno_gpu *gpu) @@ -239,7 +239,7 @@ static inline int adreno_is_a540(struct adreno_gpu *gpu) static inline int adreno_is_a618(struct adreno_gpu *gpu) { - return gpu->revn == 618; + return gpu->revn == 618; } static inline int adreno_is_a619(struct adreno_gpu *gpu) @@ -249,7 +249,7 @@ static inline int adreno_is_a619(struct adreno_gpu *gpu) static inline int adreno_is_a630(struct adreno_gpu *gpu) { - return gpu->revn == 630; + return gpu->revn == 630; } static inline int adreno_is_a640_family(struct adreno_gpu *gpu) @@ -259,18 +259,18 @@ static inline int adreno_is_a640_family(struct adreno_gpu *gpu) static inline int adreno_is_a650(struct adreno_gpu *gpu) { - return gpu->revn == 650; + return gpu->revn == 650; } static inline int adreno_is_7c3(struct adreno_gpu *gpu) { /* The order of args is important here to handle ANY_ID correctly */ - return adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), gpu->rev); + return adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), gpu->rev); } static inline int adreno_is_a660(struct adreno_gpu *gpu) { - return gpu->revn == 660; + return gpu->revn == 660; } /* check for a615, a616, a618, a619 or any derivatives */ @@ -281,14 +281,13 @@ static inline int adreno_is_a615_family(struct adreno_gpu *gpu) static inline int adreno_is_a660_family(struct adreno_gpu *gpu) { - return adreno_is_a660(gpu) || adreno_is_7c3(gpu); + return adreno_is_a660(gpu) || adreno_is_7c3(gpu); } /* check for a650, a660, or any derivatives */ static inline int adreno_is_a650_family(struct adreno_gpu *gpu) { - return gpu->revn == 650 || gpu->revn == 620 || - adreno_is_a660_family(gpu); + return gpu->revn == 650 || gpu->revn == 620 || adreno_is_a660_family(gpu); } int adreno_get_param(struct msm_gpu *gpu, struct msm_file_private *ctx,
Leading spaces are not something checkpatch likes, and it says so when they are present. Use tabs consistently to indent function body and unwrap a 83-char-long line, as 100 is cool nowadays. Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org> --- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)