| Message ID | 20220608120723.2987843-8-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/hdmi: YAML-ify schema and cleanup some platform properties | expand |
Quoting Dmitry Baryshkov (2022-06-08 05:07:18) > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > driver code doesn't support these regulators. Enable them for HDMI on > 8996 platform. The 'vdda-supply' name makes me think this is another scenario where the phy isn't powering on the analog supply when it should be and so the controller driver is doing it instead. Is that the case here? > > Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996") > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, 9 Jun 2022 at 00:02, Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Dmitry Baryshkov (2022-06-08 05:07:18) > > DB820c makes use of core-vcc-supply and core-vdda-supply, however the > > driver code doesn't support these regulators. Enable them for HDMI on > > 8996 platform. > > The 'vdda-supply' name makes me think this is another scenario where the > phy isn't powering on the analog supply when it should be and so the > controller driver is doing it instead. Is that the case here? Good question. There are different HDMI pins on 8996, with slight disagreement between the schematics and the datasheet. vcca_hdmi/vdd_hdmi1: 0.925V, Power for HDMI circuits – low voltage vdda_hdmi/vdd_hdmi2: 1.8V, Power for HDMI circuits – high voltage vdda_hdmi_pll/vdd_pll3, 1.8V, Power for PLL circuits I'm not sure which are required for the PHY and which are required for the core HDMI. However I'd note that we have a generic tendency of duplicating pins between the HDMI and the PHY devices. Compare this with 8064, where core-vdda-supply is also used both by the hdmi-tx and hdmi-phy devices. I think we unify 8x74/84 with 8996 and allow powering up the HDMI correctly even if it results in duplication between the -phy and -tx parts.
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 7cb687458a56..67397fff645c 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -399,7 +399,7 @@ static struct hdmi_platform_config hdmi_tx_8994_config = { }; static struct hdmi_platform_config hdmi_tx_8996_config = { - HDMI_CFG(pwr_reg, none), + HDMI_CFG(pwr_reg, 8x74), HDMI_CFG(hpd_reg, none), HDMI_CFG(pwr_clk, 8x74), HDMI_CFG(hpd_clk, 8x74),
DB820c makes use of core-vcc-supply and core-vdda-supply, however the driver code doesn't support these regulators. Enable them for HDMI on 8996 platform. Fixes: 0afbe59edd3f ("drm/msm/hdmi: Add basic HDMI support for msm8996") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)