| Message ID | 20220614095835.1398708-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] drm/bridge: ti-sn65dsi83: add more dev_err_probe | expand |
On Tue, 14 Jun 2022 at 11:58, Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > > Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER > might have several causes, these messages help finding the origin. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > * New in v2 > > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > index b27c0d7c451a..a306150a8027 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -677,7 +677,7 @@ static int sn65dsi83_probe(struct i2c_client *client, > ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", > GPIOD_OUT_LOW); > if (IS_ERR(ctx->enable_gpio)) > - return PTR_ERR(ctx->enable_gpio); > + return dev_err_probe(dev, PTR_ERR(ctx->enable_gpio), "failed to get enable GPIO\n"); > > usleep_range(10000, 11000); > > @@ -687,7 +687,7 @@ static int sn65dsi83_probe(struct i2c_client *client, > > ctx->regmap = devm_regmap_init_i2c(client, &sn65dsi83_regmap_config); > if (IS_ERR(ctx->regmap)) > - return PTR_ERR(ctx->regmap); > + return dev_err_probe(dev, PTR_ERR(ctx->regmap), "failed to get regmap\n"); > > dev_set_drvdata(dev, ctx); > i2c_set_clientdata(client, ctx); > -- > 2.25.1 > Reviewed & applied series to drm-misc-next. Reviewed-by: Robert Foss <robert.foss@linaro.org>
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index b27c0d7c451a..a306150a8027 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -677,7 +677,7 @@ static int sn65dsi83_probe(struct i2c_client *client, ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(ctx->enable_gpio)) - return PTR_ERR(ctx->enable_gpio); + return dev_err_probe(dev, PTR_ERR(ctx->enable_gpio), "failed to get enable GPIO\n"); usleep_range(10000, 11000); @@ -687,7 +687,7 @@ static int sn65dsi83_probe(struct i2c_client *client, ctx->regmap = devm_regmap_init_i2c(client, &sn65dsi83_regmap_config); if (IS_ERR(ctx->regmap)) - return PTR_ERR(ctx->regmap); + return dev_err_probe(dev, PTR_ERR(ctx->regmap), "failed to get regmap\n"); dev_set_drvdata(dev, ctx); i2c_set_clientdata(client, ctx);
Add more warning/debug messages during probe. E.g. a single -EPROBE_DEFER might have several causes, these messages help finding the origin. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- * New in v2 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)