From patchwork Sat Jun 18 02:56:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liang He X-Patchwork-Id: 12886193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D27AC43334 for ; Sat, 18 Jun 2022 02:57:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AB7B113206; Sat, 18 Jun 2022 02:57:08 +0000 (UTC) Received: from m15112.mail.126.com (m15112.mail.126.com [220.181.15.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 99187113206 for ; Sat, 18 Jun 2022 02:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Y2R0w LWoS3MlLi/kilNMf914qQrU9POFF5jg8cOKHx0=; b=LYPCGa8upCP5Yy3flrbhF D1nrL9Wfzi1wUM0sUooiKt8cwngQ0YCjUSOaiebuLI2yQPlmuXJ1+Z4CQe0lg0Et cXx/kxJP24Y8kVwPKelIMPXCRMYLrMaPc0H/4Sy3hQrlyypsKEyO2CViDmDDn9iz XhmCtObl+7tmlZplZNWdgI= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp2 (Coremail) with SMTP id DMmowAD3SATvPq1ifd5nDg--.23620S2; Sat, 18 Jun 2022 10:56:48 +0800 (CST) From: Liang He To: deller@gmx.de, christophe.leroy@csgroup.eu Subject: [PATCH] video: fbdev: Fix refcount leak bug in valkyriefb.c Date: Sat, 18 Jun 2022 10:56:47 +0800 Message-Id: <20220618025647.4057077-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: DMmowAD3SATvPq1ifd5nDg--.23620S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jw4UJF17Jw1kWw1fCFyrCrg_yoW3Krb_uF 1kZrZrGryUtr10gw1vgr45uryYvFWxWF1xZFn7t393Cry7Zr15Xr1Ivr1Ik34DW348GF98 ZrnFgr10yw1S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRtLvKUUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/xtbBGgEkF1-HZUnXDAAAsH X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: windhl@126.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In valkyriefb_init(), of_find_node_by_name() will return a node pointer with refcount incremented. We should use of_node_put() in fail path or when it is not used anymore. Signed-off-by: Liang He --- drivers/video/fbdev/valkyriefb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c index a6c9d4f26669..20d727a8069d 100644 --- a/drivers/video/fbdev/valkyriefb.c +++ b/drivers/video/fbdev/valkyriefb.c @@ -334,10 +334,13 @@ int __init valkyriefb_init(void) return 0; if (of_address_to_resource(dp, 0, &r)) { + of_node_put(dp); printk(KERN_ERR "can't find address for valkyrie\n"); return 0; } + of_node_put(dp); + frame_buffer_phys = r.start; cmap_regs_phys = r.start + 0x304000; }