| Message ID | 20220620010300.1532713-2-dmitry.baryshkov@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/msm/hdmi: turn MSM8996 HDMI PHY into OF clock provider | expand |
On 20/06/2022 03:02, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Jun 20, 2022 at 04:02:58AM +0300, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > .../devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Doesn't apply, so no checks ran. > > diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > index eea2e02678ed..41e6492d4a0f 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > @@ -28,12 +28,14 @@ properties: > - const: hdmi_phy > > clocks: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > clock-names: > items: > - const: iface > - const: ref > + - const: xo minItems: 2 > > power-domains: > maxItems: 1 > @@ -44,6 +46,9 @@ properties: > vddio-supply: > description: phandle to VDD I/O supply regulator > > + '#clock-cells': > + const: 0 > + > '#phy-cells': > const: 0 > > @@ -75,9 +80,12 @@ examples: > "hdmi_phy"; > > clocks = <&mmcc 116>, > - <&gcc 214>; > + <&gcc 214>, > + <&xo_board>; > clock-names = "iface", > - "ref"; > + "ref", > + "xo"; > + #clock-cells = <0>; > #phy-cells = <0>; > > vddio-supply = <&vreg_l12a_1p8>; > -- > 2.35.1 > >
On Mon, 27 Jun 2022 at 20:17, Rob Herring <robh@kernel.org> wrote: > > On Mon, Jun 20, 2022 at 04:02:58AM +0300, Dmitry Baryshkov wrote: > > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > > property. For the compatibility with older DTs the property is not > > marked as required. Also add the XO clock to the list of the clocks used > > by the driver. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > .../devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > Doesn't apply, so no checks ran. Dependencies: https://patchwork.freedesktop.org/series/105285/. I'll include this in v3. > > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > > index eea2e02678ed..41e6492d4a0f 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml > > @@ -28,12 +28,14 @@ properties: > > - const: hdmi_phy > > > > clocks: > > - maxItems: 2 > > + minItems: 2 > > + maxItems: 3 > > > > clock-names: > > items: > > - const: iface > > - const: ref > > + - const: xo > > minItems: 2 Ack > > > > > power-domains: > > maxItems: 1 > > @@ -44,6 +46,9 @@ properties: > > vddio-supply: > > description: phandle to VDD I/O supply regulator > > > > + '#clock-cells': > > + const: 0 > > + > > '#phy-cells': > > const: 0 > > > > @@ -75,9 +80,12 @@ examples: > > "hdmi_phy"; > > > > clocks = <&mmcc 116>, > > - <&gcc 214>; > > + <&gcc 214>, > > + <&xo_board>; > > clock-names = "iface", > > - "ref"; > > + "ref", > > + "xo"; > > + #clock-cells = <0>; > > #phy-cells = <0>; > > > > vddio-supply = <&vreg_l12a_1p8>; > > -- > > 2.35.1 > > > >
diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml index eea2e02678ed..41e6492d4a0f 100644 --- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml @@ -28,12 +28,14 @@ properties: - const: hdmi_phy clocks: - maxItems: 2 + minItems: 2 + maxItems: 3 clock-names: items: - const: iface - const: ref + - const: xo power-domains: maxItems: 1 @@ -44,6 +46,9 @@ properties: vddio-supply: description: phandle to VDD I/O supply regulator + '#clock-cells': + const: 0 + '#phy-cells': const: 0 @@ -75,9 +80,12 @@ examples: "hdmi_phy"; clocks = <&mmcc 116>, - <&gcc 214>; + <&gcc 214>, + <&xo_board>; clock-names = "iface", - "ref"; + "ref", + "xo"; + #clock-cells = <0>; #phy-cells = <0>; vddio-supply = <&vreg_l12a_1p8>;
As the QMP HDMI PHY is a clock provider, add constant #clock-cells property. For the compatibility with older DTs the property is not marked as required. Also add the XO clock to the list of the clocks used by the driver. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- .../devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)